ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
authorJiawei Wang <me@jwang.link>
Wed, 13 Mar 2024 01:58:52 +0000 (09:58 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 14 Mar 2024 14:14:34 +0000 (14:14 +0000)
This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc,
which added a quirk entry to enable the Yellow Carp (YC)
driver for the Lenovo 21J2 laptop.

Although the microphone functioned with the YC driver, it
resulted in incorrect driver usage. The Lenovo 21J2 is not a
Yellow Carp platform, but a Pink Sardine platform, which
already has an upstreamed driver.

The microphone on the Lenovo 21J2 operates correctly with the
CONFIG_SND_SOC_AMD_PS flag enabled and does not require the
quirk entry. So this patch removes the quirk entry.

Thanks to Mukunda Vijendar [1] for pointing this out.

Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/
Signed-off-by: Jiawei Wang <me@jwang.link>
Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/
Link: https://msgid.link/r/20240313015853.3573242-2-me@jwang.link
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/yc/acp6x-mach.c

index 1ab69a53174e6958fefe77c177fa7ac6477bc1bb..69c68d8e7a6b54fc1fcfc3fac3a73d58403071f5 100644 (file)
@@ -199,13 +199,6 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
                        DMI_MATCH(DMI_PRODUCT_NAME, "21HY"),
                }
        },
-       {
-               .driver_data = &acp6x_card,
-               .matches = {
-                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
-                       DMI_MATCH(DMI_PRODUCT_NAME, "21J2"),
-               }
-       },
        {
                .driver_data = &acp6x_card,
                .matches = {