s390/kdump: cleanup do_start_kdump() prototype and usage
authorAlexander Gordeev <agordeev@linux.ibm.com>
Mon, 3 Apr 2023 06:44:37 +0000 (08:44 +0200)
committerVasily Gorbik <gor@linux.ibm.com>
Wed, 19 Apr 2023 15:24:15 +0000 (17:24 +0200)
Avoid unnecessary run-time and compile-time type
conversions of do_start_kdump() function return
value and parameter.

Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
arch/s390/kernel/machine_kexec.c

index eb473fc835b2398d738a4c72f693a1a35d1dc53a..3e0fd01a192aac7e5f118de42ebb0fc150e6cc3a 100644 (file)
@@ -111,9 +111,8 @@ static noinline void __machine_kdump(void *image)
        store_status(__do_machine_kdump, image);
 }
 
-static unsigned long do_start_kdump(unsigned long addr)
+static int do_start_kdump(struct kimage *image)
 {
-       struct kimage *image = (struct kimage *) addr;
        int (*start_kdump)(int) = (void *)image->start;
        int rc;
 
@@ -134,8 +133,8 @@ static bool kdump_csum_valid(struct kimage *image)
        int rc;
 
        preempt_disable();
-       rc = call_on_stack(1, S390_lowcore.nodat_stack, unsigned long, do_start_kdump,
-                          unsigned long, (unsigned long)image);
+       rc = call_on_stack(1, S390_lowcore.nodat_stack, int, do_start_kdump,
+                          struct kimage *, image);
        preempt_enable();
        return rc == 0;
 #else