ALSA: hda/realtek: Fix LED on Zbook Studio G9
authorKai-Heng Feng <kai.heng.feng@canonical.com>
Thu, 17 Mar 2022 22:11:33 +0000 (06:11 +0800)
committerTakashi Iwai <tiwai@suse.de>
Fri, 18 Mar 2022 08:18:59 +0000 (09:18 +0100)
Commit 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops")
breaks mute and micmute LEDs because it changed the LED quirk from
ALC285_FIXUP_HP_GPIO_LED to ALC245_FIXUP_HP_GPIO_LED, so change it back
here.

Also reorder the chain of quirks to ensure LED quirk is the last one
being applied.

Fixes: 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops")
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Link: https://lore.kernel.org/r/20220317221134.566358-1-kai.heng.feng@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_realtek.c

index d7bebe3bdea7ea1ff5164c51f51e750449dc9e28..0a9ad35d34c1503b1390789943c381f668550e8c 100644 (file)
@@ -8773,9 +8773,9 @@ static const struct hda_fixup alc269_fixups[] = {
        },
        [ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED] = {
                .type = HDA_FIXUP_FUNC,
-               .v.func = alc245_fixup_hp_gpio_led,
+               .v.func = cs35l41_fixup_spi_four,
                .chained = true,
-               .chain_id = ALC245_FIXUP_CS35L41_SPI_4,
+               .chain_id = ALC285_FIXUP_HP_GPIO_LED,
        },
        [ALC285_FIXUP_HP_SPEAKERS_MICMUTE_LED] = {
                .type = HDA_FIXUP_VERBS,