scsi: libsas: Use sas_phy_match_port_addr() instead of open coding it
authorJason Yan <yanaijie@huawei.com>
Wed, 28 Sep 2022 07:01:30 +0000 (15:01 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 18 Oct 2022 03:28:10 +0000 (03:28 +0000)
The SAS address comparison of asd_sas_port and expander phy is open
coded. Replace it with sas_phy_match_port_addr().

Signed-off-by: Jason Yan <yanaijie@huawei.com>
Link: https://lore.kernel.org/r/20220928070130.3657183-9-yanaijie@huawei.com
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/libsas/sas_expander.c

index caa0b228673356697332dc5b1a58b369ae331424..2907ca5d0ed436f72d4221e68b1e598c1fca57a8 100644 (file)
@@ -1005,8 +1005,7 @@ static int sas_ex_discover_dev(struct domain_device *dev, int phy_id)
        }
 
        /* Parent and domain coherency */
-       if (!dev->parent && (SAS_ADDR(ex_phy->attached_sas_addr) ==
-                            SAS_ADDR(dev->port->sas_addr))) {
+       if (!dev->parent && sas_phy_match_port_addr(dev->port, ex_phy)) {
                sas_add_parent_port(dev, phy_id);
                return 0;
        }