clk: ti: dra7: disable the RNG and TIMER12 clkctrl clocks on HS devices
authorTero Kristo <t-kristo@ti.com>
Thu, 4 Apr 2019 08:11:05 +0000 (11:11 +0300)
committerStephen Boyd <sboyd@kernel.org>
Thu, 25 Apr 2019 17:51:36 +0000 (10:51 -0700)
RNG and TIMER12 are reserved for secure side usage only on HS devices,
so disable their clkctrl clocks on HS SoCs also.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
Tested-by: Andrew F. Davis <afd@ti.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
arch/arm/mach-omap2/clock.c
drivers/clk/ti/clk-7xx-compat.c
drivers/clk/ti/clk-7xx.c
drivers/clk/ti/clkctrl.c
drivers/clk/ti/clock.h
include/linux/clk/ti.h

index 42881f21cede1659fbe3518ad0da1df2d42f96d9..3e0f09cc00289035032da0418dd7665a6a0481ca 100644 (file)
@@ -119,6 +119,9 @@ void __init ti_clk_init_features(void)
        if (cpu_is_omap343x())
                features.flags |= TI_CLK_DPLL_HAS_FREQSEL;
 
+       if (omap_type() == OMAP2_DEVICE_TYPE_GP)
+               features.flags |= TI_CLK_DEVICE_TYPE_GP;
+
        /* Idlest value for interface clocks.
         * 24xx uses 0 to indicate not ready, and 1 to indicate ready.
         * 34xx reverses this, just to keep us on our toes
index 0d53bd0998bacf7df0fd0bad914214e3b1c7c107..b3cd2296f84bd261cc0394d53e3d85e859f21e5b 100644 (file)
@@ -662,7 +662,7 @@ static const struct omap_clkctrl_reg_data dra7_l4per_clkctrl_regs[] __initconst
        { DRA7_AES1_CLKCTRL, NULL, CLKF_HW_SUP, "l3_iclk_div", "l4sec_clkdm" },
        { DRA7_AES2_CLKCTRL, NULL, CLKF_HW_SUP, "l3_iclk_div", "l4sec_clkdm" },
        { DRA7_DES_CLKCTRL, NULL, CLKF_HW_SUP, "l3_iclk_div", "l4sec_clkdm" },
-       { DRA7_RNG_CLKCTRL, NULL, CLKF_HW_SUP, "l3_iclk_div", "l4sec_clkdm" },
+       { DRA7_RNG_CLKCTRL, NULL, CLKF_HW_SUP | CLKF_SOC_NONSEC, "l3_iclk_div", "l4sec_clkdm" },
        { DRA7_SHAM_CLKCTRL, NULL, CLKF_HW_SUP, "l3_iclk_div", "l4sec_clkdm" },
        { DRA7_UART7_CLKCTRL, dra7_uart7_bit_data, CLKF_SW_SUP, "l4per_cm:clk:01d0:24", "l4per2_clkdm" },
        { DRA7_UART8_CLKCTRL, dra7_uart8_bit_data, CLKF_SW_SUP, "l4per_cm:clk:01e0:24", "l4per2_clkdm" },
@@ -704,7 +704,7 @@ static const struct omap_clkctrl_reg_data dra7_wkupaon_clkctrl_regs[] __initcons
        { DRA7_WD_TIMER2_CLKCTRL, NULL, CLKF_SW_SUP, "sys_32k_ck" },
        { DRA7_GPIO1_CLKCTRL, dra7_gpio1_bit_data, CLKF_HW_SUP, "wkupaon_iclk_mux" },
        { DRA7_TIMER1_CLKCTRL, dra7_timer1_bit_data, CLKF_SW_SUP, "wkupaon_cm:clk:0020:24" },
-       { DRA7_TIMER12_CLKCTRL, NULL, 0, "secure_32k_clk_src_ck" },
+       { DRA7_TIMER12_CLKCTRL, NULL, CLKF_SOC_NONSEC, "secure_32k_clk_src_ck" },
        { DRA7_COUNTER_32K_CLKCTRL, NULL, 0, "wkupaon_iclk_mux" },
        { DRA7_UART10_CLKCTRL, dra7_uart10_bit_data, CLKF_SW_SUP, "wkupaon_cm:clk:0060:24" },
        { DRA7_DCAN1_CLKCTRL, dra7_dcan1_bit_data, CLKF_SW_SUP, "wkupaon_cm:clk:0068:24" },
index 098c342d9c3615b47830add4720cbed5249643f4..79186b918d8725fdfc4b66c74028b3d03e7ad632 100644 (file)
@@ -590,7 +590,7 @@ static const struct omap_clkctrl_reg_data dra7_l4sec_clkctrl_regs[] __initconst
        { DRA7_L4SEC_AES1_CLKCTRL, NULL, CLKF_HW_SUP, "l3_iclk_div" },
        { DRA7_L4SEC_AES2_CLKCTRL, NULL, CLKF_HW_SUP, "l3_iclk_div" },
        { DRA7_L4SEC_DES_CLKCTRL, NULL, CLKF_HW_SUP, "l3_iclk_div" },
-       { DRA7_L4SEC_RNG_CLKCTRL, NULL, CLKF_HW_SUP, "" },
+       { DRA7_L4SEC_RNG_CLKCTRL, NULL, CLKF_HW_SUP | CLKF_SOC_NONSEC, "" },
        { DRA7_L4SEC_SHAM_CLKCTRL, NULL, CLKF_HW_SUP, "l3_iclk_div" },
        { 0 },
 };
@@ -757,7 +757,7 @@ static const struct omap_clkctrl_reg_data dra7_wkupaon_clkctrl_regs[] __initcons
        { DRA7_WKUPAON_WD_TIMER2_CLKCTRL, NULL, CLKF_SW_SUP, "sys_32k_ck" },
        { DRA7_WKUPAON_GPIO1_CLKCTRL, dra7_gpio1_bit_data, CLKF_HW_SUP, "wkupaon_iclk_mux" },
        { DRA7_WKUPAON_TIMER1_CLKCTRL, dra7_timer1_bit_data, CLKF_SW_SUP, "wkupaon-clkctrl:0020:24" },
-       { DRA7_WKUPAON_TIMER12_CLKCTRL, NULL, 0, "secure_32k_clk_src_ck" },
+       { DRA7_WKUPAON_TIMER12_CLKCTRL, NULL, CLKF_SOC_NONSEC, "secure_32k_clk_src_ck" },
        { DRA7_WKUPAON_COUNTER_32K_CLKCTRL, NULL, 0, "wkupaon_iclk_mux" },
        { DRA7_WKUPAON_UART10_CLKCTRL, dra7_uart10_bit_data, CLKF_SW_SUP, "wkupaon-clkctrl:0060:24" },
        { DRA7_WKUPAON_DCAN1_CLKCTRL, dra7_dcan1_bit_data, CLKF_SW_SUP, "wkupaon-clkctrl:0068:24" },
index 4cdeb8d4830cf0c5cc38ef2e270451fea09018b9..96d65a1cf7be15bbee8ac91e48562c27623c013d 100644 (file)
@@ -509,6 +509,9 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node)
                data = dm816_clkctrl_data;
 #endif
 
+       if (ti_clk_get_features()->flags & TI_CLK_DEVICE_TYPE_GP)
+               soc_mask |= CLKF_SOC_NONSEC;
+
        while (data->addr) {
                if (addr == data->addr)
                        break;
index 773e2c4ac390d4c30518930969f673fbe3c03f1b..e4b8392ff63c05d654413a0ec3bf2954a853480c 100644 (file)
@@ -83,11 +83,12 @@ enum {
 #define CLKF_HW_SUP                    BIT(6)
 #define CLKF_NO_IDLEST                 BIT(7)
 
-#define CLKF_SOC_MASK                  GENMASK(10, 8)
+#define CLKF_SOC_MASK                  GENMASK(11, 8)
 
-#define CLKF_SOC_DRA72                 BIT(8)
-#define CLKF_SOC_DRA74                 BIT(9)
-#define CLKF_SOC_DRA76                 BIT(10)
+#define CLKF_SOC_NONSEC                        BIT(8)
+#define CLKF_SOC_DRA72                 BIT(9)
+#define CLKF_SOC_DRA74                 BIT(10)
+#define CLKF_SOC_DRA76                 BIT(11)
 
 #define CLK(dev, con, ck)              \
        {                               \
index 2821f7cb1ca9055bddfe69e19f55f7a4b5fd747f..1e8ef96555ce4c260e68063103e054beefac7b6d 100644 (file)
@@ -294,6 +294,7 @@ struct ti_clk_features {
 #define TI_CLK_DISABLE_CLKDM_CONTROL           BIT(2)
 #define TI_CLK_ERRATA_I810                     BIT(3)
 #define TI_CLK_CLKCTRL_COMPAT                  BIT(4)
+#define TI_CLK_DEVICE_TYPE_GP                  BIT(5)
 
 void ti_clk_setup_features(struct ti_clk_features *features);
 const struct ti_clk_features *ti_clk_get_features(void);