net: lan966x: Do not check 0 for platform_get_irq_byname()
authorZhu Wang <wangzhu9@huawei.com>
Thu, 3 Aug 2023 08:29:00 +0000 (16:29 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 4 Aug 2023 10:10:33 +0000 (11:10 +0100)
Since platform_get_irq_byname() never returned zero, so it need not to
check whether it returned zero, it returned -EINVAL or -ENXIO when
failed, so we replace the return error code with the result it returned.

Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/microchip/lan966x/lan966x_main.c

index 4a1acc7234f6471dbdf2ca97c2e5e66e5d698e32..0d6e79af241067720cbd097673e260c405f0b191 100644 (file)
@@ -1119,8 +1119,8 @@ static int lan966x_probe(struct platform_device *pdev)
 
        /* set irq */
        lan966x->xtr_irq = platform_get_irq_byname(pdev, "xtr");
-       if (lan966x->xtr_irq <= 0)
-               return -EINVAL;
+       if (lan966x->xtr_irq < 0)
+               return lan966x->xtr_irq;
 
        err = devm_request_threaded_irq(&pdev->dev, lan966x->xtr_irq, NULL,
                                        lan966x_xtr_irq_handler, IRQF_ONESHOT,