staging: r8188eu: remove code to set led1 registers

This driver uses only led0. Remove the register settings to switch led1
on and off.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20211207210537.23382-3-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_led.c b/drivers/staging/r8188eu/hal/rtl8188eu_led.c
index 0d2d658af5bb02b349151632ec8e327eafb2b15f..dd692d6a3ab7148efbdce8b1306d80857e8cb64f 100644 (file)
--- a/drivers/staging/r8188eu/hal/rtl8188eu_led.c
+++ b/drivers/staging/r8188eu/hal/rtl8188eu_led.c
@@ -17,17 +17,9 @@ void SwLedOn(struct adapter *padapter, struct LED_871x *pLed)
 
        if (padapter->bSurpriseRemoved || padapter->bDriverStopped)
                return;
+
        LedCfg = rtw_read8(padapter, REG_LEDCFG2);
-       switch (pLed->LedPin) {
-       case LED_PIN_LED0:
-               rtw_write8(padapter, REG_LEDCFG2, (LedCfg & 0xf0) | BIT(5) | BIT(6)); /*  SW control led0 on. */
-               break;
-       case LED_PIN_LED1:
-               rtw_write8(padapter, REG_LEDCFG2, (LedCfg & 0x0f) | BIT(5)); /*  SW control led1 on. */
-               break;
-       default:
-               break;
-       }
+       rtw_write8(padapter, REG_LEDCFG2, (LedCfg & 0xf0) | BIT(5) | BIT(6)); /*  SW control led0 on. */
        pLed->bLedOn = true;
 }
 
@@ -42,21 +34,11 @@ void SwLedOff(struct adapter *padapter, struct LED_871x *pLed)
 
        LedCfg = rtw_read8(padapter, REG_LEDCFG2);/* 0x4E */
 
-       switch (pLed->LedPin) {
-       case LED_PIN_LED0:
-               LedCfg &= 0x90; /*  Set to software control. */
-               rtw_write8(padapter, REG_LEDCFG2, (LedCfg | BIT(3)));
-               LedCfg = rtw_read8(padapter, REG_MAC_PINMUX_CFG);
-               LedCfg &= 0xFE;
-               rtw_write8(padapter, REG_MAC_PINMUX_CFG, LedCfg);
-               break;
-       case LED_PIN_LED1:
-               LedCfg &= 0x0f; /*  Set to software control. */
-               rtw_write8(padapter, REG_LEDCFG2, (LedCfg | BIT(3)));
-               break;
-       default:
-               break;
-       }
+       LedCfg &= 0x90; /*  Set to software control. */
+       rtw_write8(padapter, REG_LEDCFG2, (LedCfg | BIT(3)));
+       LedCfg = rtw_read8(padapter, REG_MAC_PINMUX_CFG);
+       LedCfg &= 0xFE;
+       rtw_write8(padapter, REG_MAC_PINMUX_CFG, LedCfg);
 exit:
        pLed->bLedOn = false;
 }

diff --git a/drivers/staging/r8188eu/include/rtw_led.h b/drivers/staging/r8188eu/include/rtw_led.h
index 87c41ac6f701da198a7dd73afb6a569f62571d7a..ff182878e3712178082b980403619bc09851ab1b 100644 (file)
--- a/drivers/staging/r8188eu/include/rtw_led.h
+++ b/drivers/staging/r8188eu/include/rtw_led.h
@@ -53,7 +53,6 @@ enum LED_STATE_871x {
 
 enum LED_PIN_871x {
        LED_PIN_LED0 = 1,
-       LED_PIN_LED1 = 2,
 };
 
 struct LED_871x {