f2fs: fix to check return value of f2fs_recover_xattr_data

Should check return value of f2fs_recover_xattr_data in
__f2fs_setxattr rather than doing invalid retry if error happen.

Also just do set_page_dirty in f2fs_recover_xattr_data when
page is changed really.

Fixes: 50a472bbc79f ("f2fs: do not return EFSCORRUPTED, but try to run online repair")
Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 6c7f6a649d272fbfe7139063976bf96bf043255a..9b546fd2101004c306d83bb5a33a11e53a88b7c7 100644 (file)
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -2751,11 +2751,11 @@ recover_xnid:
        f2fs_update_inode_page(inode);
 
        /* 3: update and set xattr node page dirty */
-       if (page)
+       if (page) {
                memcpy(F2FS_NODE(xpage), F2FS_NODE(page),
                                VALID_XATTR_BLOCK_SIZE);
-
-       set_page_dirty(xpage);
+               set_page_dirty(xpage);
+       }
        f2fs_put_page(xpage, 1);
 
        return 0;

diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c
index a8fc2cac68799508d9a2eb83bc568a64779f1369..f290fe9327c4987cb5317465acccbebe2bc93581 100644 (file)
--- a/fs/f2fs/xattr.c
+++ b/fs/f2fs/xattr.c
@@ -660,11 +660,14 @@ retry:
        here = __find_xattr(base_addr, last_base_addr, NULL, index, len, name);
        if (!here) {
                if (!F2FS_I(inode)->i_xattr_nid) {
+                       error = f2fs_recover_xattr_data(inode, NULL);
                        f2fs_notice(F2FS_I_SB(inode),
-                               "recover xattr in inode (%lu)", inode->i_ino);
-                       f2fs_recover_xattr_data(inode, NULL);
-                       kfree(base_addr);
-                       goto retry;
+                               "recover xattr in inode (%lu), error(%d)",
+                                       inode->i_ino, error);
+                       if (!error) {
+                               kfree(base_addr);
+                               goto retry;
+                       }
                }
                f2fs_err(F2FS_I_SB(inode), "set inode (%lu) has corrupted xattr",
                                                                inode->i_ino);