projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f801556
)
mfd: intel_soc_pmic_bxtwc: Use sysfs_emit() instead of sprintf()
author
Andy Shevchenko
<andriy.shevchenko@linux.intel.com>
Tue, 28 Jun 2022 22:17:45 +0000
(
01:17
+0300)
committer
Lee Jones
<lee@kernel.org>
Tue, 19 Jul 2022 09:54:42 +0000
(10:54 +0100)
sysfs_emit() is preferred over sprintf() when formatting the value to be
returned to user space in show() functions, because it knows about sysfs
buffer specifics and has sanity checks.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link:
https://lore.kernel.org/r/20220628221747.33956-9-andriy.shevchenko@linux.intel.com
drivers/mfd/intel_soc_pmic_bxtwc.c
patch
|
blob
|
history
diff --git
a/drivers/mfd/intel_soc_pmic_bxtwc.c
b/drivers/mfd/intel_soc_pmic_bxtwc.c
index 5ac623eda1c1127e19e93324abeec8d3c0e8dfcd..db7bda114d2dfc1abe3ce9822196e8e9ef0ee69a 100644
(file)
--- a/
drivers/mfd/intel_soc_pmic_bxtwc.c
+++ b/
drivers/mfd/intel_soc_pmic_bxtwc.c
@@
-334,7
+334,7
@@
static unsigned long bxtwc_reg_addr;
static ssize_t addr_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
- return s
printf
(buf, "0x%lx\n", bxtwc_reg_addr);
+ return s
ysfs_emit
(buf, "0x%lx\n", bxtwc_reg_addr);
}
static ssize_t addr_store(struct device *dev,
@@
-362,7
+362,7
@@
static ssize_t val_show(struct device *dev,
return ret;
}
- return s
printf
(buf, "0x%02x\n", val);
+ return s
ysfs_emit
(buf, "0x%02x\n", val);
}
static ssize_t val_store(struct device *dev,