get_maintainer: use 'https://' instead of 'git://'
authorStefan Hajnoczi <stefanha@redhat.com>
Thu, 8 Nov 2018 11:15:25 +0000 (11:15 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 12 Nov 2018 11:26:02 +0000 (11:26 +0000)
When you clone the repository without previous commit history, 'git://'
doesn't protect from man-in-the-middle attacks.  HTTPS is more secure
since the client verifies the server certificate.

Reported-by: Jann Horn <jannh@google.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 20181108111531.30671-3-stefanha@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
scripts/get_maintainer.pl

index 43fb5f512f70d8f7b32681393b564dcee51c1e67..71415e3c706106958eb0a85cb98e921ba73077a9 100755 (executable)
@@ -1376,7 +1376,7 @@ sub vcs_exists {
        warn("$P: No supported VCS found.  Add --nogit to options?\n");
        warn("Using a git repository produces better results.\n");
        warn("Try latest git repository using:\n");
-       warn("git clone git://git.qemu.org/qemu.git\n");
+       warn("git clone https://git.qemu.org/git/qemu.git\n");
        $printed_novcs = 1;
     }
     return 0;