habanalabs: fix return value check in hl_fw_get_sec_attest_data()
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 23 Sep 2022 14:39:13 +0000 (22:39 +0800)
committerOded Gabbay <ogabbay@kernel.org>
Wed, 23 Nov 2022 14:13:39 +0000 (16:13 +0200)
If hl_cpu_accessible_dma_pool_alloc() fails, we should check
'req_cpu_addr', fix it.

Fixes: 0c88760f8f5e ("habanalabs/gaudi2: add secured attestation info uapi")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/misc/habanalabs/common/firmware_if.c

index 2de6a9bd564de351e27c3db867537eeb4473275f..f18e53bbba6bb5a2a313a44b83755425e49c87cc 100644 (file)
@@ -2983,7 +2983,7 @@ static int hl_fw_get_sec_attest_data(struct hl_device *hdev, u32 packet_id, void
        int rc;
 
        req_cpu_addr = hl_cpu_accessible_dma_pool_alloc(hdev, size, &req_dma_addr);
-       if (!data) {
+       if (!req_cpu_addr) {
                dev_err(hdev->dev,
                        "Failed to allocate DMA memory for CPU-CP packet %u\n", packet_id);
                return -ENOMEM;