media: bcm2835-unicam: Depend on COMMON_CLK
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Sun, 12 May 2024 22:21:04 +0000 (01:21 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Tue, 14 May 2024 06:09:05 +0000 (08:09 +0200)
The bcm2835-unicam driver calls the clk_set_min_rate() function, which
is declared but not implemented on platforms that don't provide
COMMON_CLK. This causes linkage failures with some configurations.

Fix it by depending on COMMON_CLK. This only slightly restricts
compilation testing, but not usage of the driver as all platforms on
which the hardware can be found provide COMMON_CLK.

Fixes: 392cd78d495f ("media: bcm2835-unicam: Add support for CCP2/CSI2 camera interface")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202405112243.2MLRT7li-lkp@intel.com/
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/broadcom/Kconfig

index cc2c9afcc948b0c0b3e6b5bf02b81aaaf73ef863..32b76ebfcd9a194e285381fc4f1d0fbac7d62b4d 100644 (file)
@@ -3,7 +3,7 @@
 config VIDEO_BCM2835_UNICAM
        tristate "Broadcom BCM283x/BCM271x Unicam video capture driver"
        depends on ARCH_BCM2835 || COMPILE_TEST
-       depends on PM
+       depends on COMMON_CLK && PM
        depends on VIDEO_DEV
        select MEDIA_CONTROLLER
        select V4L2_FWNODE