thermal: imx8mm: Use dev_err_probe() to simplify error handling
authorAnson Huang <Anson.Huang@nxp.com>
Tue, 11 Aug 2020 06:59:45 +0000 (14:59 +0800)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Mon, 12 Oct 2020 10:08:35 +0000 (12:08 +0200)
dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/1597129185-8460-2-git-send-email-Anson.Huang@nxp.com
drivers/thermal/imx8mm_thermal.c

index f5124f14cf81386126c540841410c7c2d5b74679..a1e4f9bb4cb01e7eb17538d1597759c8ec1ae557 100644 (file)
@@ -146,13 +146,9 @@ static int imx8mm_tmu_probe(struct platform_device *pdev)
                return PTR_ERR(tmu->base);
 
        tmu->clk = devm_clk_get(&pdev->dev, NULL);
-       if (IS_ERR(tmu->clk)) {
-               ret = PTR_ERR(tmu->clk);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&pdev->dev,
-                               "failed to get tmu clock: %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(tmu->clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(tmu->clk),
+                                    "failed to get tmu clock\n");
 
        ret = clk_prepare_enable(tmu->clk);
        if (ret) {