EDAC/xgene: Remove set but not used address local var
authorJason Yan <yanaijie@huawei.com>
Thu, 9 Apr 2020 09:32:59 +0000 (17:32 +0800)
committerBorislav Petkov <bp@suse.de>
Tue, 14 Apr 2020 12:35:19 +0000 (14:35 +0200)
Fix the following gcc warning:

  drivers/edac/xgene_edac.c:1486:7: warning: variable ‘address’ set but
  not used [-Wunused-but-set-variable]
     u32 address;
         ^~~~~~~
Remove the unused macro RBERRADDR_RD while at it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200409093259.20069-1-yanaijie@huawei.com
drivers/edac/xgene_edac.c

index e4a1032ba0b58a4e93dc055e94dce2181c351277..1d2c27a00a4a8348eb5e0d0c203eafa4520c7030 100644 (file)
@@ -1349,7 +1349,6 @@ static int xgene_edac_l3_remove(struct xgene_edac_dev_ctx *l3)
 #define WORD_ALIGNED_ERR_MASK          BIT(28)
 #define PAGE_ACCESS_ERR_MASK           BIT(27)
 #define WRITE_ACCESS_MASK              BIT(26)
-#define RBERRADDR_RD(src)              ((src) & 0x03FFFFFF)
 
 static const char * const soc_mem_err_v1[] = {
        "10GbE0",
@@ -1483,13 +1482,11 @@ static void xgene_edac_rb_report(struct edac_device_ctl_info *edac_dev)
                return;
        if (reg & STICKYERR_MASK) {
                bool write;
-               u32 address;
 
                dev_err(edac_dev->dev, "IOB bus access error(s)\n");
                if (regmap_read(ctx->edac->rb_map, RBEIR, &reg))
                        return;
                write = reg & WRITE_ACCESS_MASK ? 1 : 0;
-               address = RBERRADDR_RD(reg);
                if (reg & AGENT_OFFLINE_ERR_MASK)
                        dev_err(edac_dev->dev,
                                "IOB bus %s access to offline agent error\n",