wlcore: fix bug reading fwlog
authorRussell King <rmk+kernel@armlinux.org.uk>
Thu, 3 Jun 2021 11:54:24 +0000 (12:54 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 14 Jun 2021 15:49:42 +0000 (18:49 +0300)
With logging enabled, it has been observed that the driver spews
messages such as:

wlcore: ERROR Calculate of clear addr Clear = 204025b0, write = 204015b0

The problem occurs because 204025b0 is the end of the buffer, and
204015b0 is the beginning, and the calculation for "clear"ing the
buffer does not take into account that if we read to the very end
of the ring buffer, we are actually at the beginning of the buffer.

Fix this.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/E1lolvc-0003RM-VE@rmk-PC.armlinux.org.uk
drivers/net/wireless/ti/wlcore/event.c

index 875198fb14809ecf064606e6bf55275f9c41985a..8a67a708c96eb976279932e55e1e58422de4feda 100644 (file)
@@ -84,6 +84,8 @@ int wlcore_event_fw_logger(struct wl1271 *wl)
        len = min(actual_len, available_len);
        wl12xx_copy_fwlog(wl, &buffer[start_loc], len);
        clear_ptr = addr_ptr + start_loc + actual_len;
+       if (clear_ptr == buff_end_ptr)
+               clear_ptr = buff_start_ptr;
 
        /* Copy any remaining part from beginning of ring buffer */
        len = actual_len - len;