pinctrl: amd: Don't show `Invalid config param` errors
authorMario Limonciello <mario.limonciello@amd.com>
Mon, 17 Jul 2023 20:16:52 +0000 (15:16 -0500)
committerLinus Walleij <linus.walleij@linaro.org>
Sun, 23 Jul 2023 19:41:06 +0000 (21:41 +0200)
On some systems amd_pinconf_set() is called with parameters
0x8 (PIN_CONFIG_DRIVE_PUSH_PULL) or 0x14 (PIN_CONFIG_PERSIST_STATE)
which are not supported by pinctrl-amd.

Don't show an err message when called with an invalid parameter,
downgrade this to debug instead.

Cc: stable@vger.kernel.org # 6.1
Fixes: 635a750d958e1 ("pinctrl: amd: Use amd_pinconf_set() for all config options")
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20230717201652.17168-1-mario.limonciello@amd.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-amd.c

index 3c4220be30ecb8c80840e8ee70aa8811c342a0b2..baa3629f71a20724a3c5b333d0c2c61996329ece 100644 (file)
@@ -769,7 +769,7 @@ static int amd_pinconf_get(struct pinctrl_dev *pctldev,
                break;
 
        default:
-               dev_err(&gpio_dev->pdev->dev, "Invalid config param %04x\n",
+               dev_dbg(&gpio_dev->pdev->dev, "Invalid config param %04x\n",
                        param);
                return -ENOTSUPP;
        }
@@ -822,7 +822,7 @@ static int amd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
                        break;
 
                default:
-                       dev_err(&gpio_dev->pdev->dev,
+                       dev_dbg(&gpio_dev->pdev->dev,
                                "Invalid config param %04x\n", param);
                        ret = -ENOTSUPP;
                }