Should not use assignment in if condition.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
                netdev_err(dev, "port already open\n");
                return -EIO;
        }
-       if ((i = hdlc_open(dev)) != 0)
+
+       i = hdlc_open(dev);
+       if (i)
                return i;
 
        port->tx_in = port->tx_out = 0;
 
        timeout = jiffies + 5 * HZ;
        do {
-               if ((stat = readl(card->plx + PLX_MAILBOX_5)) != 0)
+               stat = readl(card->plx + PLX_MAILBOX_5);
+               if (stat)
                        break;
                schedule();
        } while (time_after(timeout, jiffies));