selftests: x86: ksft_exit_pass() does not return
authorNathan Chancellor <nathan@kernel.org>
Wed, 24 Apr 2024 17:24:12 +0000 (10:24 -0700)
committerShuah Khan <skhan@linuxfoundation.org>
Mon, 6 May 2024 19:57:21 +0000 (13:57 -0600)
After commit f7d5bcd35d42 ("selftests: kselftest: Mark functions that
unconditionally call exit() as __noreturn"), ksft_exit_...() functions
are marked as __noreturn, which means the return type should not be
'int' but 'void' because they are not returning anything (and never were
since exit() has always been called).

To facilitate updating the return type of these functions, remove
'return' before the call to ksft_exit_pass(), as __noreturn prevents the
compiler from warning that a caller of ksft_exit_pass() does not return
a value because the program will terminate upon calling these functions.

Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/x86/lam.c

index 215b8150b7ccad447b5369b39b34a1bdae42ee85..820db486429206854f753127a70304d755565e4e 100644 (file)
@@ -1237,5 +1237,5 @@ int main(int argc, char **argv)
 
        ksft_set_plan(tests_cnt);
 
-       return ksft_exit_pass();
+       ksft_exit_pass();
 }