drm/amd/display: Use swap() instead of open coding it
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Thu, 9 Mar 2023 02:52:50 +0000 (10:52 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 13 Mar 2023 21:15:05 +0000 (17:15 -0400)
Swap is a function interface that provides exchange function. To avoid
code duplication, we can use swap function.

./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:359:57-58: WARNING opportunity for swap().

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4448
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index ae994c6c65ac46ae49db5e18198cb9ef7af53dbf..f6d9bbce15b2fbb236379aced4bbf842451dcb0d 100644 (file)
@@ -352,13 +352,9 @@ static inline void reverse_planes_order(struct dc_surface_update *array_of_surfa
                                        int planes_count)
 {
        int i, j;
-       struct dc_surface_update surface_updates_temp;
 
-       for (i = 0, j = planes_count - 1; i < j; i++, j--) {
-               surface_updates_temp = array_of_surface_update[i];
-               array_of_surface_update[i] = array_of_surface_update[j];
-               array_of_surface_update[j] = surface_updates_temp;
-       }
+       for (i = 0, j = planes_count - 1; i < j; i++, j--)
+               swap(array_of_surface_update[i], array_of_surface_update[j]);
 }
 
 /**