staging: vchiq: Fix bulk transfers on 64-bit builds
authorPhil Elwell <phil@raspberrypi.com>
Tue, 5 Jan 2021 16:20:29 +0000 (16:20 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 7 Jan 2021 15:56:47 +0000 (16:56 +0100)
The recent change to the bulk transfer compat function missed the fact
the relevant ioctl command is VCHIQ_IOC_QUEUE_BULK_TRANSMIT32, not
VCHIQ_IOC_QUEUE_BULK_TRANSMIT, as any attempt to send a bulk block
to the VPU would have shown.

Fixes: a4367cd2b231 ("staging: vchiq: convert compat bulk transfer")
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Link: https://lore.kernel.org/r/20210105162030.1415213-3-phil@raspberrypi.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

index 4d645afeb50f9d0423d1ebc01b4cbc7461a9454f..23f4389cf51dfc4cb0e37bc1576c3e21b5d27a3f 100644 (file)
@@ -1710,7 +1710,7 @@ vchiq_compat_ioctl_queue_bulk(struct file *file,
 {
        struct vchiq_queue_bulk_transfer32 args32;
        struct vchiq_queue_bulk_transfer args;
-       enum vchiq_bulk_dir dir = (cmd == VCHIQ_IOC_QUEUE_BULK_TRANSMIT) ?
+       enum vchiq_bulk_dir dir = (cmd == VCHIQ_IOC_QUEUE_BULK_TRANSMIT32) ?
                                  VCHIQ_BULK_TRANSMIT : VCHIQ_BULK_RECEIVE;
 
        if (copy_from_user(&args32, argp, sizeof(args32)))