clk: at91: clk-master: improve readability by using local variables
authorClaudiu Beznea <claudiu.beznea@microchip.com>
Mon, 11 Oct 2021 11:27:09 +0000 (14:27 +0300)
committerStephen Boyd <sboyd@kernel.org>
Wed, 27 Oct 2021 01:27:42 +0000 (18:27 -0700)
Improve readability in clk_sama7g5_master_set() by using local
variables.

Suggested-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Link: https://lore.kernel.org/r/20211011112719.3951784-6-claudiu.beznea@microchip.com
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/at91/clk-master.c

index 88f7af1bfff6722a6b1e48a8de6163131c32ed95..9a2c8e64cacf97c16d8ad32d1ffe9a3ee9eff6e1 100644 (file)
@@ -680,6 +680,8 @@ static void clk_sama7g5_master_set(struct clk_master *master,
        unsigned long flags;
        unsigned int val, cparent;
        unsigned int enable = status ? AT91_PMC_MCR_V2_EN : 0;
+       unsigned int parent = master->parent << PMC_MCR_CSS_SHIFT;
+       unsigned int div = master->div << MASTER_DIV_SHIFT;
 
        spin_lock_irqsave(master->lock, flags);
 
@@ -689,9 +691,7 @@ static void clk_sama7g5_master_set(struct clk_master *master,
        regmap_update_bits(master->regmap, AT91_PMC_MCR_V2,
                           enable | AT91_PMC_MCR_V2_CSS | AT91_PMC_MCR_V2_DIV |
                           AT91_PMC_MCR_V2_CMD | AT91_PMC_MCR_V2_ID_MSK,
-                          enable | (master->parent << PMC_MCR_CSS_SHIFT) |
-                          (master->div << MASTER_DIV_SHIFT) |
-                          AT91_PMC_MCR_V2_CMD |
+                          enable | parent | div | AT91_PMC_MCR_V2_CMD |
                           AT91_PMC_MCR_V2_ID(master->id));
 
        cparent = (val & AT91_PMC_MCR_V2_CSS) >> PMC_MCR_CSS_SHIFT;