mips: setup: use strscpy to replace strlcpy
author陈学兵 <chenxuebing@jari.cn>
Sun, 22 May 2022 07:46:18 +0000 (15:46 +0800)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Mon, 23 May 2022 09:29:48 +0000 (11:29 +0200)
The strlcpy should not be used because it doesn't limit the source
length. Preferred is strscpy.

Signed-off-by: XueBing Chen <chenxuebing@jari.cn>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/kernel/setup.c

index ef73ba1e0ec10474dd108c89445608039a4043ab..ad3aea81d0e2a329e887fe27c59b8f489a829927 100644 (file)
@@ -554,7 +554,7 @@ static void __init bootcmdline_init(void)
         * unmodified.
         */
        if (IS_ENABLED(CONFIG_CMDLINE_OVERRIDE)) {
-               strlcpy(boot_command_line, builtin_cmdline, COMMAND_LINE_SIZE);
+               strscpy(boot_command_line, builtin_cmdline, COMMAND_LINE_SIZE);
                return;
        }
 
@@ -566,7 +566,7 @@ static void __init bootcmdline_init(void)
         * boot_command_line to undo anything early_init_dt_scan_chosen() did.
         */
        if (IS_ENABLED(CONFIG_MIPS_CMDLINE_BUILTIN_EXTEND))
-               strlcpy(boot_command_line, builtin_cmdline, COMMAND_LINE_SIZE);
+               strscpy(boot_command_line, builtin_cmdline, COMMAND_LINE_SIZE);
        else
                boot_command_line[0] = 0;
 
@@ -628,7 +628,7 @@ static void __init arch_mem_init(char **cmdline_p)
        memblock_set_bottom_up(true);
 
        bootcmdline_init();
-       strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE);
+       strscpy(command_line, boot_command_line, COMMAND_LINE_SIZE);
        *cmdline_p = command_line;
 
        parse_early_param();