drm/amd/display: Fix out of bounds access on DNC31 stream encoder regs
authorNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Tue, 7 Dec 2021 14:46:39 +0000 (09:46 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 10:03:31 +0000 (11:03 +0100)
[ Upstream commit d374d3b493215d637b9e7be12a93f22caf4c1f97 ]

[Why]
During dcn31_stream_encoder_create, if PHYC/D get remapped to F/G on B0
then we'll index 5 or 6 into a array of length 5 - leading to an
access violation on some configs during device creation.

[How]
Software won't be touching PHYF/PHYG directly, so just extend the
array to cover all possible engine IDs.

Even if it does by try to access one of these registers by accident
the offset will be 0 and we'll get a warning during the access.

Fixes: 2fe9a0e1173f ("drm/amd/display: Fix DCN3 B0 DP Alt Mapping")
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c

index 0fe570717ba01f38cab4508f1267e8169ffedf5f..d4fe5352421fc8f1276cd29450599f3918011f42 100644 (file)
@@ -470,7 +470,8 @@ static const struct dcn30_afmt_mask afmt_mask = {
        SE_DCN3_REG_LIST(id)\
 }
 
-static const struct dcn10_stream_enc_registers stream_enc_regs[] = {
+/* Some encoders won't be initialized here - but they're logical, not physical. */
+static const struct dcn10_stream_enc_registers stream_enc_regs[ENGINE_ID_COUNT] = {
        stream_enc_regs(0),
        stream_enc_regs(1),
        stream_enc_regs(2),