thermal: exynos: check return values of ->get_trip_[temp, hyst] methods
authorBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Thu, 26 Apr 2018 11:51:30 +0000 (13:51 +0200)
committerEduardo Valentin <edubezval@gmail.com>
Sun, 6 May 2018 23:42:05 +0000 (16:42 -0700)
Check return values of ->get_trip_[temp,hyst] methods in
exynos_tmu_initialize().

Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
drivers/thermal/samsung/exynos_tmu.c

index 8cb8601a80cac9a8cfb20165eb1a180eeb40bef2..ff72f71a00781922db9869822bcb985e4f787d24 100644 (file)
@@ -357,19 +357,23 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
                /* Write temperature code for rising and falling threshold */
                for (i = 0; i < ntrips; i++) {
                        /* Write temperature code for rising threshold */
-                       tzd->ops->get_trip_temp(tzd, i, &temp);
+                       ret = tzd->ops->get_trip_temp(tzd, i, &temp);
+                       if (ret)
+                               goto err;
                        temp /= MCELSIUS;
                        data->tmu_set_trip_temp(data, i, temp);
 
                        /* Write temperature code for falling threshold */
-                       tzd->ops->get_trip_hyst(tzd, i, &hyst);
+                       ret = tzd->ops->get_trip_hyst(tzd, i, &hyst);
+                       if (ret)
+                               goto err;
                        hyst /= MCELSIUS;
                        data->tmu_set_trip_hyst(data, i, temp, hyst);
                }
 
                data->tmu_clear_irqs(data);
        }
-
+err:
        clk_disable(data->clk);
        mutex_unlock(&data->lock);
        if (!IS_ERR(data->clk_sec))