pinctrl/rockchip: Add missing of_node_put() in rockchip_pinctrl_probe
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 7 Mar 2022 12:02:34 +0000 (12:02 +0000)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 15 Mar 2022 01:23:52 +0000 (02:23 +0100)
The device_node pointer is returned by of_parse_phandle()  with refcount
incremented. We should use of_node_put() on it when done.

Fixes: 1e747e59cc4d ("pinctrl: rockchip: base regmap supplied by a syscon")
Fixes: 14dee8677e19 ("pinctrl: rockchip: let pmu registers be supplied by a syscon")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220307120234.28657-1-linmq006@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-rockchip.c

index d8dd8415fa81b9f9f50daf2cb34ec65982fc75a2..a1b598b86aa9f400133fe0649db24a7b5cfa7f82 100644 (file)
@@ -2693,6 +2693,7 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev)
        node = of_parse_phandle(np, "rockchip,grf", 0);
        if (node) {
                info->regmap_base = syscon_node_to_regmap(node);
+               of_node_put(node);
                if (IS_ERR(info->regmap_base))
                        return PTR_ERR(info->regmap_base);
        } else {
@@ -2725,6 +2726,7 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev)
        node = of_parse_phandle(np, "rockchip,pmu", 0);
        if (node) {
                info->regmap_pmu = syscon_node_to_regmap(node);
+               of_node_put(node);
                if (IS_ERR(info->regmap_pmu))
                        return PTR_ERR(info->regmap_pmu);
        }