media: omap4iss: return error code when omap4iss_get() failed
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 17 Nov 2020 02:50:41 +0000 (03:50 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 11 Mar 2021 10:59:45 +0000 (11:59 +0100)
If omap4iss_get() failed, it need return error code in iss_probe().

Fixes: 59f0ad807681 ("[media] v4l: omap4iss: Add support for OMAP4...")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/omap4iss/iss.c

index dae9073e7d3cc8576d09b11e4d48037de59854fa..085397045b36d49ecdeb49ad32ee6ac4a0288ab7 100644 (file)
@@ -1236,8 +1236,10 @@ static int iss_probe(struct platform_device *pdev)
        if (ret < 0)
                goto error;
 
-       if (!omap4iss_get(iss))
+       if (!omap4iss_get(iss)) {
+               ret = -EINVAL;
                goto error;
+       }
 
        ret = iss_reset(iss);
        if (ret < 0)