macvlan: remove redundant null check on data
authorYunjian Wang <wangyunjian@huawei.com>
Tue, 5 Jan 2021 06:31:34 +0000 (14:31 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 6 Jan 2021 00:52:02 +0000 (16:52 -0800)
Because macvlan_common_newlink() and macvlan_changelink() already
checked NULL data parameter, so the additional check is unnecessary,
just remove it.

Fixes: 79cf79abce71 ("macvlan: add source mode")
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/macvlan.c

index fb51329f89645066b3531a00a0c87f44b356ca8f..9a9a5cf36a4b673afe1f60ae0fdcc2cd5bb64b6b 100644 (file)
@@ -1385,7 +1385,7 @@ static int macvlan_changelink_sources(struct macvlan_dev *vlan, u32 mode,
                                return ret;
                }
 
-               if (!data || !data[IFLA_MACVLAN_MACADDR_DATA])
+               if (!data[IFLA_MACVLAN_MACADDR_DATA])
                        return 0;
 
                head = nla_data(data[IFLA_MACVLAN_MACADDR_DATA]);