mtd: rawnand: qcom: Implement exec_op()
authorMd Sadre Alam <quic_mdalam@quicinc.com>
Mon, 10 Jul 2023 05:44:39 +0000 (11:14 +0530)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Sat, 15 Jul 2023 16:05:38 +0000 (18:05 +0200)
Implement exec_op() so we can later get rid of the legacy
interface implementation.

Co-developed-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20230710054440.23297-1-quic_mdalam@quicinc.com
drivers/mtd/nand/raw/qcom_nandc.c

index 72d6168d8a1be0c8c7d139a1bcf758d0f387d2db..852c6a203c78c833069b35a889c702c3f5b61b55 100644 (file)
 #define        OP_PAGE_PROGRAM_WITH_ECC        0x7
 #define        OP_PROGRAM_PAGE_SPARE           0x9
 #define        OP_BLOCK_ERASE                  0xa
+#define        OP_CHECK_STATUS                 0xc
 #define        OP_FETCH_ID                     0xb
 #define        OP_RESET_DEVICE                 0xd
 
@@ -235,6 +236,8 @@ nandc_set_reg(chip, reg,                    \
  */
 #define NAND_ERASED_CW_SET             BIT(4)
 
+#define MAX_ADDRESS_CYCLE              5
+
 /*
  * This data type corresponds to the BAM transaction which will be used for all
  * NAND transfers.
@@ -382,6 +385,9 @@ struct nandc_regs {
  * @reg_read_pos:              marker for data read in reg_read_buf
  *
  * @cmd1/vld:                  some fixed controller register values
+ *
+ * @exec_opwrite:              flag to select correct number of code word
+ *                             while reading status
  */
 struct qcom_nand_controller {
        struct device *dev;
@@ -432,6 +438,7 @@ struct qcom_nand_controller {
        int reg_read_pos;
 
        u32 cmd1, vld;
+       bool exec_opwrite;
 };
 
 /*
@@ -447,6 +454,29 @@ struct qcom_nand_boot_partition {
        u32 page_size;
 };
 
+/*
+ * Qcom op for each exec_op transfer
+ *
+ * @data_instr:                        data instruction pointer
+ * @data_instr_idx:            data instruction index
+ * @rdy_timeout_ms:            wait ready timeout in ms
+ * @rdy_delay_ns:              Additional delay in ns
+ * @addr1_reg:                 Address1 register value
+ * @addr2_reg:                 Address2 register value
+ * @cmd_reg:                   CMD register value
+ * @flag:                      flag for misc instruction
+ */
+struct qcom_op {
+       const struct nand_op_instr *data_instr;
+       unsigned int data_instr_idx;
+       unsigned int rdy_timeout_ms;
+       unsigned int rdy_delay_ns;
+       u32 addr1_reg;
+       u32 addr2_reg;
+       u32 cmd_reg;
+       u8 flag;
+};
+
 /*
  * NAND chip structure
  *
@@ -1516,9 +1546,7 @@ static void pre_command(struct qcom_nand_host *host, int command)
 
        clear_read_regs(nandc);
 
-       if (command == NAND_CMD_RESET || command == NAND_CMD_READID ||
-           command == NAND_CMD_PARAM || command == NAND_CMD_ERASE1)
-               clear_bam_transaction(nandc);
+       clear_bam_transaction(nandc);
 }
 
 /*
@@ -2154,12 +2182,20 @@ static int qcom_nandc_read_page(struct nand_chip *chip, uint8_t *buf,
 {
        struct qcom_nand_host *host = to_qcom_nand_host(chip);
        struct qcom_nand_controller *nandc = get_qcom_nand_controller(chip);
+       struct nand_ecc_ctrl *ecc = &chip->ecc;
        u8 *data_buf, *oob_buf = NULL;
 
        if (host->nr_boot_partitions)
                qcom_nandc_codeword_fixup(host, page);
 
        nand_read_page_op(chip, page, 0, NULL, 0);
+       nandc->buf_count = 0;
+       nandc->buf_start = 0;
+       host->use_ecc = true;
+       clear_read_regs(nandc);
+       set_address(host, 0, page);
+       update_rw_regs(host, ecc->steps, true, 0);
+
        data_buf = buf;
        oob_buf = oob_required ? chip->oob_poi : NULL;
 
@@ -2229,6 +2265,9 @@ static int qcom_nandc_write_page(struct nand_chip *chip, const uint8_t *buf,
 
        nand_prog_page_begin_op(chip, page, 0, NULL, 0);
 
+       set_address(host, 0, page);
+       nandc->buf_count = 0;
+       nandc->buf_start = 0;
        clear_read_regs(nandc);
        clear_bam_transaction(nandc);
 
@@ -2867,8 +2906,497 @@ static int qcom_nand_attach_chip(struct nand_chip *chip)
        return 0;
 }
 
+static int qcom_op_cmd_mapping(struct qcom_nand_controller *nandc, u8 cmd,
+                              struct qcom_op *q_op)
+{
+       int ret;
+
+       switch (cmd) {
+       case NAND_CMD_RESET:
+               ret = OP_RESET_DEVICE;
+               break;
+       case NAND_CMD_READID:
+               ret = OP_FETCH_ID;
+               break;
+       case NAND_CMD_PARAM:
+               if (nandc->props->qpic_v2)
+                       ret = OP_PAGE_READ_ONFI_READ;
+               else
+                       ret = OP_PAGE_READ;
+               break;
+       case NAND_CMD_ERASE1:
+       case NAND_CMD_ERASE2:
+               ret = OP_BLOCK_ERASE;
+               break;
+       case NAND_CMD_STATUS:
+               ret = OP_CHECK_STATUS;
+               break;
+       case NAND_CMD_PAGEPROG:
+               ret = OP_PROGRAM_PAGE;
+               q_op->flag = OP_PROGRAM_PAGE;
+               nandc->exec_opwrite = true;
+               break;
+       }
+
+       return ret;
+}
+
+/* NAND framework ->exec_op() hooks and related helpers */
+static void qcom_parse_instructions(struct nand_chip *chip,
+                                   const struct nand_subop *subop,
+                                       struct qcom_op *q_op)
+{
+       struct qcom_nand_controller *nandc = get_qcom_nand_controller(chip);
+       const struct nand_op_instr *instr = NULL;
+       unsigned int op_id;
+       int i;
+
+       memset(q_op, 0, sizeof(*q_op));
+
+       for (op_id = 0; op_id < subop->ninstrs; op_id++) {
+               unsigned int offset, naddrs;
+               const u8 *addrs;
+
+               instr = &subop->instrs[op_id];
+
+               switch (instr->type) {
+               case NAND_OP_CMD_INSTR:
+                       q_op->cmd_reg = qcom_op_cmd_mapping(nandc, instr->ctx.cmd.opcode, q_op);
+                       q_op->rdy_delay_ns = instr->delay_ns;
+                       break;
+
+               case NAND_OP_ADDR_INSTR:
+                       offset = nand_subop_get_addr_start_off(subop, op_id);
+                       naddrs = nand_subop_get_num_addr_cyc(subop, op_id);
+                       addrs = &instr->ctx.addr.addrs[offset];
+                       for (i = 0; i < MAX_ADDRESS_CYCLE; i++) {
+                               if (i < 4)
+                                       q_op->addr1_reg |= (u32)addrs[i] << i * 8;
+                               else
+                                       q_op->addr2_reg |= addrs[i];
+                       }
+                       q_op->rdy_delay_ns = instr->delay_ns;
+                       break;
+
+               case NAND_OP_DATA_IN_INSTR:
+                       q_op->data_instr = instr;
+                       q_op->data_instr_idx = op_id;
+                       q_op->rdy_delay_ns = instr->delay_ns;
+                       fallthrough;
+               case NAND_OP_DATA_OUT_INSTR:
+                       q_op->rdy_delay_ns = instr->delay_ns;
+                       break;
+
+               case NAND_OP_WAITRDY_INSTR:
+                       q_op->rdy_timeout_ms = instr->ctx.waitrdy.timeout_ms;
+                       q_op->rdy_delay_ns = instr->delay_ns;
+                       break;
+               }
+       }
+}
+
+static void qcom_delay_ns(unsigned int ns)
+{
+       if (!ns)
+               return;
+
+       if (ns < 10000)
+               ndelay(ns);
+       else
+               udelay(DIV_ROUND_UP(ns, 1000));
+}
+
+static int qcom_wait_rdy_poll(struct nand_chip *chip, unsigned int time_ms)
+{
+       struct qcom_nand_controller *nandc = get_qcom_nand_controller(chip);
+       unsigned long start = jiffies + msecs_to_jiffies(time_ms);
+       u32 flash;
+
+       nandc_read_buffer_sync(nandc, true);
+
+       do {
+               flash = le32_to_cpu(nandc->reg_read_buf[0]);
+               if (flash & FS_READY_BSY_N)
+                       return 0;
+               cpu_relax();
+       } while (time_after(start, jiffies));
+
+       dev_err(nandc->dev, "Timeout waiting for device to be ready:0x%08x\n", flash);
+
+       return -ETIMEDOUT;
+}
+
+static int qcom_read_status_exec(struct nand_chip *chip,
+                                const struct nand_subop *subop)
+{
+       struct qcom_nand_host *host = to_qcom_nand_host(chip);
+       struct qcom_nand_controller *nandc = get_qcom_nand_controller(chip);
+       struct nand_ecc_ctrl *ecc = &chip->ecc;
+       struct qcom_op q_op;
+       const struct nand_op_instr *instr = NULL;
+       unsigned int op_id = 0;
+       unsigned int len = 0;
+       int ret = 0, num_cw, i;
+       u32 flash_status;
+
+       host->status = NAND_STATUS_READY | NAND_STATUS_WP;
+
+       qcom_parse_instructions(chip, subop, &q_op);
+
+       num_cw = nandc->exec_opwrite ? ecc->steps : 1;
+       nandc->exec_opwrite = false;
+
+       nandc->buf_count = 0;
+       nandc->buf_start = 0;
+       host->use_ecc = false;
+
+       clear_read_regs(nandc);
+       clear_bam_transaction(nandc);
+
+       nandc_set_reg(chip, NAND_FLASH_CMD, q_op.cmd_reg);
+       nandc_set_reg(chip, NAND_EXEC_CMD, 1);
+
+       write_reg_dma(nandc, NAND_FLASH_CMD, 1, NAND_BAM_NEXT_SGL);
+       write_reg_dma(nandc, NAND_EXEC_CMD, 1, NAND_BAM_NEXT_SGL);
+       read_reg_dma(nandc, NAND_FLASH_STATUS, 1, NAND_BAM_NEXT_SGL);
+
+       ret = submit_descs(nandc);
+       if (ret) {
+               dev_err(nandc->dev, "failure in submitting status descriptor\n");
+               free_descs(nandc);
+               goto err_out;
+       }
+       free_descs(nandc);
+
+       nandc_read_buffer_sync(nandc, true);
+
+       for (i = 0; i < num_cw; i++) {
+               flash_status = le32_to_cpu(nandc->reg_read_buf[i]);
+
+       if (flash_status & FS_MPU_ERR)
+               host->status &= ~NAND_STATUS_WP;
+
+       if (flash_status & FS_OP_ERR ||
+        (i == (num_cw - 1) && (flash_status & FS_DEVICE_STS_ERR)))
+               host->status |= NAND_STATUS_FAIL;
+       }
+
+       flash_status = host->status;
+       instr = q_op.data_instr;
+       op_id = q_op.data_instr_idx;
+       len = nand_subop_get_data_len(subop, op_id);
+       memcpy(instr->ctx.data.buf.in, &flash_status, len);
+
+err_out:
+       return ret;
+}
+
+static int qcom_read_id_type_exec(struct nand_chip *chip, const struct nand_subop *subop)
+{
+       struct qcom_nand_controller *nandc = get_qcom_nand_controller(chip);
+       struct qcom_nand_host *host = to_qcom_nand_host(chip);
+       struct qcom_op q_op;
+       const struct nand_op_instr *instr = NULL;
+       unsigned int op_id = 0;
+       unsigned int len = 0;
+       int ret = 0;
+
+       qcom_parse_instructions(chip, subop, &q_op);
+
+       nandc->buf_count = 0;
+       nandc->buf_start = 0;
+       host->use_ecc = false;
+
+       clear_read_regs(nandc);
+       clear_bam_transaction(nandc);
+
+       nandc_set_reg(chip, NAND_FLASH_CMD, q_op.cmd_reg);
+       nandc_set_reg(chip, NAND_ADDR0, q_op.addr1_reg);
+       nandc_set_reg(chip, NAND_ADDR1, q_op.addr2_reg);
+       nandc_set_reg(chip, NAND_FLASH_CHIP_SELECT,
+                     nandc->props->is_bam ? 0 : DM_EN);
+
+       nandc_set_reg(chip, NAND_EXEC_CMD, 1);
+
+       write_reg_dma(nandc, NAND_FLASH_CMD, 4, NAND_BAM_NEXT_SGL);
+       write_reg_dma(nandc, NAND_EXEC_CMD, 1, NAND_BAM_NEXT_SGL);
+
+       read_reg_dma(nandc, NAND_READ_ID, 1, NAND_BAM_NEXT_SGL);
+
+       ret = submit_descs(nandc);
+       if (ret) {
+               dev_err(nandc->dev, "failure in submitting read id descriptor\n");
+               free_descs(nandc);
+               goto err_out;
+       }
+       free_descs(nandc);
+
+       instr = q_op.data_instr;
+       op_id = q_op.data_instr_idx;
+       len = nand_subop_get_data_len(subop, op_id);
+
+       nandc_read_buffer_sync(nandc, true);
+       memcpy(instr->ctx.data.buf.in, nandc->reg_read_buf, len);
+
+err_out:
+       return ret;
+}
+
+static int qcom_misc_cmd_type_exec(struct nand_chip *chip, const struct nand_subop *subop)
+{
+       struct qcom_nand_controller *nandc = get_qcom_nand_controller(chip);
+       struct qcom_nand_host *host = to_qcom_nand_host(chip);
+       struct qcom_op q_op;
+       int ret = 0;
+
+       qcom_parse_instructions(chip, subop, &q_op);
+
+       if (q_op.flag == OP_PROGRAM_PAGE)
+               goto wait_rdy;
+
+       nandc->buf_count = 0;
+       nandc->buf_start = 0;
+       host->use_ecc = false;
+
+       clear_read_regs(nandc);
+       clear_bam_transaction(nandc);
+
+       nandc_set_reg(chip, NAND_FLASH_CMD, q_op.cmd_reg);
+       nandc_set_reg(chip, NAND_EXEC_CMD, 1);
+
+       write_reg_dma(nandc, NAND_FLASH_CMD, 1, NAND_BAM_NEXT_SGL);
+       write_reg_dma(nandc, NAND_EXEC_CMD, 1, NAND_BAM_NEXT_SGL);
+
+       read_reg_dma(nandc, NAND_FLASH_STATUS, 1, NAND_BAM_NEXT_SGL);
+
+       ret = submit_descs(nandc);
+       if (ret) {
+               dev_err(nandc->dev, "failure in submitting misc descriptor\n");
+               free_descs(nandc);
+               goto err_out;
+       }
+       free_descs(nandc);
+
+wait_rdy:
+       qcom_delay_ns(q_op.rdy_delay_ns);
+       ret = qcom_wait_rdy_poll(chip, q_op.rdy_timeout_ms);
+
+err_out:
+       return ret;
+}
+
+static int qcom_param_page_type_exec(struct nand_chip *chip,  const struct nand_subop *subop)
+{
+       struct qcom_nand_host *host = to_qcom_nand_host(chip);
+       struct qcom_nand_controller *nandc = get_qcom_nand_controller(chip);
+       struct qcom_op q_op;
+       const struct nand_op_instr *instr = NULL;
+       unsigned int op_id = 0;
+       unsigned int len = 0;
+       int ret = 0;
+
+       qcom_parse_instructions(chip, subop, &q_op);
+
+       q_op.cmd_reg |= PAGE_ACC | LAST_PAGE;
+
+       nandc->buf_count = 0;
+       nandc->buf_start = 0;
+       host->use_ecc = false;
+       clear_read_regs(nandc);
+       clear_bam_transaction(nandc);
+
+       nandc_set_reg(chip, NAND_FLASH_CMD, q_op.cmd_reg);
+
+       nandc_set_reg(chip, NAND_ADDR0, 0);
+       nandc_set_reg(chip, NAND_ADDR1, 0);
+       nandc_set_reg(chip, NAND_DEV0_CFG0, 0 << CW_PER_PAGE
+                                       | 512 << UD_SIZE_BYTES
+                                       | 5 << NUM_ADDR_CYCLES
+                                       | 0 << SPARE_SIZE_BYTES);
+       nandc_set_reg(chip, NAND_DEV0_CFG1, 7 << NAND_RECOVERY_CYCLES
+                                       | 0 << CS_ACTIVE_BSY
+                                       | 17 << BAD_BLOCK_BYTE_NUM
+                                       | 1 << BAD_BLOCK_IN_SPARE_AREA
+                                       | 2 << WR_RD_BSY_GAP
+                                       | 0 << WIDE_FLASH
+                                       | 1 << DEV0_CFG1_ECC_DISABLE);
+       if (!nandc->props->qpic_v2)
+               nandc_set_reg(chip, NAND_EBI2_ECC_BUF_CFG, 1 << ECC_CFG_ECC_DISABLE);
+
+       /* configure CMD1 and VLD for ONFI param probing in QPIC v1 */
+       if (!nandc->props->qpic_v2) {
+               nandc_set_reg(chip, NAND_DEV_CMD_VLD,
+                             (nandc->vld & ~READ_START_VLD));
+               nandc_set_reg(chip, NAND_DEV_CMD1,
+                             (nandc->cmd1 & ~(0xFF << READ_ADDR))
+                             | NAND_CMD_PARAM << READ_ADDR);
+       }
+
+       nandc_set_reg(chip, NAND_EXEC_CMD, 1);
+
+       if (!nandc->props->qpic_v2) {
+               nandc_set_reg(chip, NAND_DEV_CMD1_RESTORE, nandc->cmd1);
+               nandc_set_reg(chip, NAND_DEV_CMD_VLD_RESTORE, nandc->vld);
+       }
+
+       instr = q_op.data_instr;
+       op_id = q_op.data_instr_idx;
+       len = nand_subop_get_data_len(subop, op_id);
+
+       nandc_set_read_loc(chip, 0, 0, 0, len, 1);
+
+       if (!nandc->props->qpic_v2) {
+               write_reg_dma(nandc, NAND_DEV_CMD_VLD, 1, 0);
+               write_reg_dma(nandc, NAND_DEV_CMD1, 1, NAND_BAM_NEXT_SGL);
+       }
+
+       nandc->buf_count = len;
+       memset(nandc->data_buffer, 0xff, nandc->buf_count);
+
+       config_nand_single_cw_page_read(chip, false, 0);
+
+       read_data_dma(nandc, FLASH_BUF_ACC, nandc->data_buffer,
+                     nandc->buf_count, 0);
+
+       /* restore CMD1 and VLD regs */
+       if (!nandc->props->qpic_v2) {
+               write_reg_dma(nandc, NAND_DEV_CMD1_RESTORE, 1, 0);
+               write_reg_dma(nandc, NAND_DEV_CMD_VLD_RESTORE, 1, NAND_BAM_NEXT_SGL);
+       }
+
+       ret = submit_descs(nandc);
+       if (ret) {
+               dev_err(nandc->dev, "failure in submitting param page descriptor\n");
+               free_descs(nandc);
+               goto err_out;
+       }
+       free_descs(nandc);
+
+       ret = qcom_wait_rdy_poll(chip, q_op.rdy_timeout_ms);
+       if (ret)
+               goto err_out;
+
+       memcpy(instr->ctx.data.buf.in, nandc->data_buffer, len);
+
+err_out:
+       return ret;
+}
+
+static int qcom_erase_cmd_type_exec(struct nand_chip *chip, const struct nand_subop *subop)
+{
+       struct qcom_nand_host *host = to_qcom_nand_host(chip);
+       struct qcom_nand_controller *nandc = get_qcom_nand_controller(chip);
+       struct qcom_op q_op;
+       int ret = 0;
+
+       qcom_parse_instructions(chip, subop, &q_op);
+
+       q_op.cmd_reg |= PAGE_ACC | LAST_PAGE;
+
+       nandc->buf_count = 0;
+       nandc->buf_start = 0;
+       host->use_ecc = false;
+       clear_read_regs(nandc);
+       clear_bam_transaction(nandc);
+
+       nandc_set_reg(chip, NAND_FLASH_CMD, q_op.cmd_reg);
+       nandc_set_reg(chip, NAND_ADDR0, q_op.addr1_reg);
+       nandc_set_reg(chip, NAND_ADDR1, q_op.addr2_reg);
+       nandc_set_reg(chip, NAND_DEV0_CFG0,
+                     host->cfg0_raw & ~(7 << CW_PER_PAGE));
+       nandc_set_reg(chip, NAND_DEV0_CFG1, host->cfg1_raw);
+       nandc_set_reg(chip, NAND_EXEC_CMD, 1);
+
+       write_reg_dma(nandc, NAND_FLASH_CMD, 3, NAND_BAM_NEXT_SGL);
+       write_reg_dma(nandc, NAND_DEV0_CFG0, 2, NAND_BAM_NEXT_SGL);
+       write_reg_dma(nandc, NAND_EXEC_CMD, 1, NAND_BAM_NEXT_SGL);
+
+       ret = submit_descs(nandc);
+       if (ret) {
+               dev_err(nandc->dev, "failure in submitting erase descriptor\n");
+               free_descs(nandc);
+               goto err_out;
+       }
+       free_descs(nandc);
+
+       ret = qcom_wait_rdy_poll(chip, q_op.rdy_timeout_ms);
+       if (ret)
+               goto err_out;
+
+err_out:
+       return ret;
+}
+
+static const struct nand_op_parser qcom_op_parser = NAND_OP_PARSER(
+               NAND_OP_PARSER_PATTERN(
+                       qcom_misc_cmd_type_exec,
+                       NAND_OP_PARSER_PAT_CMD_ELEM(false),
+                       NAND_OP_PARSER_PAT_WAITRDY_ELEM(false)),
+               NAND_OP_PARSER_PATTERN(
+                       qcom_read_id_type_exec,
+                       NAND_OP_PARSER_PAT_CMD_ELEM(false),
+                       NAND_OP_PARSER_PAT_ADDR_ELEM(false, MAX_ADDRESS_CYCLE),
+                       NAND_OP_PARSER_PAT_DATA_IN_ELEM(false, 8)),
+               NAND_OP_PARSER_PATTERN(
+                       qcom_read_status_exec,
+                       NAND_OP_PARSER_PAT_CMD_ELEM(false),
+                       NAND_OP_PARSER_PAT_DATA_IN_ELEM(false, 1)),
+               NAND_OP_PARSER_PATTERN(
+                       qcom_param_page_type_exec,
+                       NAND_OP_PARSER_PAT_CMD_ELEM(false),
+                       NAND_OP_PARSER_PAT_ADDR_ELEM(false, MAX_ADDRESS_CYCLE),
+                       NAND_OP_PARSER_PAT_WAITRDY_ELEM(true),
+                       NAND_OP_PARSER_PAT_DATA_IN_ELEM(false, 512)),
+               NAND_OP_PARSER_PATTERN(
+                       qcom_erase_cmd_type_exec,
+                       NAND_OP_PARSER_PAT_CMD_ELEM(false),
+                       NAND_OP_PARSER_PAT_ADDR_ELEM(false, MAX_ADDRESS_CYCLE),
+                       NAND_OP_PARSER_PAT_CMD_ELEM(false),
+                       NAND_OP_PARSER_PAT_WAITRDY_ELEM(false)),
+               );
+
+static int qcom_check_op(struct nand_chip *chip,
+                        const struct nand_operation *op)
+{
+       const struct nand_op_instr *instr;
+       int op_id;
+
+       for (op_id = 0; op_id < op->ninstrs; op_id++) {
+               instr = &op->instrs[op_id];
+
+               switch (instr->type) {
+               case NAND_OP_CMD_INSTR:
+                       if (instr->ctx.cmd.opcode != NAND_CMD_RESET ||
+                           instr->ctx.cmd.opcode != NAND_CMD_READID ||
+                           instr->ctx.cmd.opcode != NAND_CMD_PARAM ||
+                           instr->ctx.cmd.opcode != NAND_CMD_ERASE1 ||
+                           instr->ctx.cmd.opcode != NAND_CMD_ERASE2 ||
+                           instr->ctx.cmd.opcode != NAND_CMD_STATUS ||
+                           instr->ctx.cmd.opcode != NAND_CMD_PAGEPROG)
+                               return -ENOTSUPP;
+                       break;
+               default:
+                       break;
+               }
+       }
+
+       return 0;
+}
+
+static int qcom_nand_exec_op(struct nand_chip *chip,
+                            const struct nand_operation *op,
+                       bool check_only)
+{
+       if (check_only)
+               return qcom_check_op(chip, op);
+
+       return nand_op_parser_exec_op(chip, &qcom_op_parser,
+                       op, check_only);
+}
+
 static const struct nand_controller_ops qcom_nandc_ops = {
        .attach_chip = qcom_nand_attach_chip,
+       .exec_op = qcom_nand_exec_op,
 };
 
 static void qcom_nandc_unalloc(struct qcom_nand_controller *nandc)