ARM: dts: exynos: correct PMIC interrupt trigger level on Snow
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 10 Dec 2020 21:25:25 +0000 (22:25 +0100)
committerKrzysztof Kozlowski <krzk@kernel.org>
Sun, 7 Mar 2021 19:56:18 +0000 (20:56 +0100)
The Maxim PMIC datasheets describe the interrupt line as active low
with a requirement of acknowledge from the CPU.  Without specifying the
interrupt type in Devicetree, kernel might apply some fixed
configuration, not necessarily working for this hardware.

Additionally, the interrupt line is shared so using level sensitive
interrupt is here especially important to avoid races.

Fixes: c61248afa819 ("ARM: dts: Add max77686 RTC interrupt to cros5250-common")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201210212534.216197-9-krzk@kernel.org
arch/arm/boot/dts/exynos5250-snow-common.dtsi

index 6635f6184051e593d74dfdea7c30408f35a1841f..2335c46873494d19bc9db14698a4b66ff10672bd 100644 (file)
        max77686: pmic@9 {
                compatible = "maxim,max77686";
                interrupt-parent = <&gpx3>;
-               interrupts = <2 IRQ_TYPE_NONE>;
+               interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
                pinctrl-names = "default";
                pinctrl-0 = <&max77686_irq>;
                wakeup-source;