auxdisplay: ht16k33: Replace use of fb_blank with backlight helper
authorThomas Zimmermann <tzimmermann@suse.de>
Tue, 19 Mar 2024 09:37:20 +0000 (10:37 +0100)
committerLee Jones <lee@kernel.org>
Thu, 28 Mar 2024 10:12:48 +0000 (10:12 +0000)
Replace the use of struct backlight_properties.fb_blank with a call
to backlight_get_brightness(). The helper implements similar logic
as the driver's function. It also accounts for BL_CORE_SUSPENDED for
drivers that set BL_CORE_SUSPENDRESUME. Ht16k33 doesn't use this, so
there's no change in behaviour here.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Robin van der Gracht <robin@protonic.nl>
Cc: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Robin van der Gracht <robin@protonic.nl>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240319093915.31778-2-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/auxdisplay/ht16k33.c

index 96acfb2b58cd9244fda53113fa54cfaa11e2ccfd..70a7b88709ff0a369d1979e3a689e24b219b093f 100644 (file)
@@ -284,14 +284,9 @@ static int ht16k33_initialize(struct ht16k33_priv *priv)
 
 static int ht16k33_bl_update_status(struct backlight_device *bl)
 {
-       int brightness = bl->props.brightness;
+       const int brightness = backlight_get_brightness(bl);
        struct ht16k33_priv *priv = bl_get_data(bl);
 
-       if (bl->props.power != FB_BLANK_UNBLANK ||
-           bl->props.fb_blank != FB_BLANK_UNBLANK ||
-           bl->props.state & BL_CORE_FBBLANK)
-               brightness = 0;
-
        return ht16k33_brightness_set(priv, brightness);
 }