rtw89: fix maybe uninitialized `qempty` variable
authorÍñigo Huguet <ihuguet@redhat.com>
Thu, 13 Jan 2022 09:42:53 +0000 (10:42 +0100)
committerKalle Valo <kvalo@kernel.org>
Fri, 28 Jan 2022 15:57:46 +0000 (17:57 +0200)
Call to dle_dfi_qempty might fail, leaving qempty.qempty untouched, which
is latter used to control the for loop. If that happens, it's not
initialized anywhere.

Initialize it so the loop doesn't iterate unless it's modified by the
call to dle_dfi_qempty.

Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220113094253.73370-1-ihuguet@redhat.com
drivers/net/wireless/realtek/rtw89/mac.c

index 0a006f3c3742d30bc41bba8b6acd26eb73c5b8fe..2e95d9007c41dbb96fe9aa0361f1b13f07f85ac2 100644 (file)
@@ -172,6 +172,7 @@ static void rtw89_mac_dump_qta_lost(struct rtw89_dev *rtwdev)
 
        qempty.dle_type = DLE_CTRL_TYPE_PLE;
        qempty.grpsel = 0;
+       qempty.qempty = ~(u32)0;
        ret = dle_dfi_qempty(rtwdev, &qempty);
        if (ret)
                rtw89_warn(rtwdev, "%s: query DLE fail\n", __func__);