i2c: riic: Use platform_get_irq() to get the interrupt
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Tue, 21 Dec 2021 17:53:22 +0000 (17:53 +0000)
committerWolfram Sang <wsa@kernel.org>
Mon, 3 Jan 2022 09:17:32 +0000 (10:17 +0100)
platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq().

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-riic.c

index 78b84445ee6aba02b6a8a55509b1bcb6a8294130..8dfd27dc61497037f95c2a9e9f3a531b78399692 100644 (file)
@@ -433,12 +433,12 @@ static int riic_i2c_probe(struct platform_device *pdev)
        }
 
        for (i = 0; i < ARRAY_SIZE(riic_irqs); i++) {
-               res = platform_get_resource(pdev, IORESOURCE_IRQ, riic_irqs[i].res_num);
-               if (!res)
-                       return -ENODEV;
+               ret = platform_get_irq(pdev, riic_irqs[i].res_num);
+               if (ret < 0)
+                       return ret;
 
-               ret = devm_request_irq(&pdev->dev, res->start, riic_irqs[i].isr,
-                                       0, riic_irqs[i].name, riic);
+               ret = devm_request_irq(&pdev->dev, ret, riic_irqs[i].isr,
+                                      0, riic_irqs[i].name, riic);
                if (ret) {
                        dev_err(&pdev->dev, "failed to request irq %s\n", riic_irqs[i].name);
                        return ret;