clocksource: Replace cpumask_weight() with cpumask_empty()
authorYury Norov <yury.norov@gmail.com>
Thu, 10 Feb 2022 22:49:07 +0000 (14:49 -0800)
committerThomas Gleixner <tglx@linutronix.de>
Sun, 10 Apr 2022 20:30:04 +0000 (22:30 +0200)
clocksource_verify_percpu() calls cpumask_weight() to check if any bit of a
given cpumask is set.

This can be done more efficiently with cpumask_empty() because
cpumask_empty() stops traversing the cpumask as soon as it finds first set
bit, while cpumask_weight() counts all bits unconditionally.

Signed-off-by: Yury Norov <yury.norov@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20220210224933.379149-24-yury.norov@gmail.com
kernel/time/clocksource.c

index 95d7ca35bdf2ce92b0a9929fd20e4356599bb032..cee5da1e54c4121d771bf5fa19c07584e000bf49 100644 (file)
@@ -343,7 +343,7 @@ void clocksource_verify_percpu(struct clocksource *cs)
        cpus_read_lock();
        preempt_disable();
        clocksource_verify_choose_cpus();
-       if (cpumask_weight(&cpus_chosen) == 0) {
+       if (cpumask_empty(&cpus_chosen)) {
                preempt_enable();
                cpus_read_unlock();
                pr_warn("Not enough CPUs to check clocksource '%s'.\n", cs->name);