dmaengine: shdmac: Convert to devm_platform_ioremap_resource()
authorYangtao Li <frank.li@vivo.com>
Wed, 5 Jul 2023 08:18:55 +0000 (16:18 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 12 Jul 2023 16:54:00 +0000 (22:24 +0530)
Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
Link: https://lore.kernel.org/r/20230705081856.13734-4-frank.li@vivo.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/sh/shdmac.c

index 5aafe548ca5f308200de9e555580e44e8bcb234a..fb3c56a416d1514d9fc3df14c4872f4cb145b523 100644 (file)
@@ -678,7 +678,7 @@ static int sh_dmae_probe(struct platform_device *pdev)
        int err, errirq, i, irq_cnt = 0, irqres = 0, irq_cap = 0;
        struct sh_dmae_device *shdev;
        struct dma_device *dma_dev;
-       struct resource *chan, *dmars, *errirq_res, *chanirq_res;
+       struct resource *dmars, *errirq_res, *chanirq_res;
 
        if (pdev->dev.of_node)
                pdata = of_device_get_match_data(&pdev->dev);
@@ -689,7 +689,6 @@ static int sh_dmae_probe(struct platform_device *pdev)
        if (!pdata || !pdata->channel_num)
                return -ENODEV;
 
-       chan = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        /* DMARS area is optional */
        dmars = platform_get_resource(pdev, IORESOURCE_MEM, 1);
        /*
@@ -709,7 +708,7 @@ static int sh_dmae_probe(struct platform_device *pdev)
         *    requested with the IRQF_SHARED flag
         */
        errirq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-       if (!chan || !errirq_res)
+       if (!errirq_res)
                return -ENODEV;
 
        shdev = devm_kzalloc(&pdev->dev, sizeof(struct sh_dmae_device),
@@ -719,7 +718,7 @@ static int sh_dmae_probe(struct platform_device *pdev)
 
        dma_dev = &shdev->shdma_dev.dma_dev;
 
-       shdev->chan_reg = devm_ioremap_resource(&pdev->dev, chan);
+       shdev->chan_reg = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(shdev->chan_reg))
                return PTR_ERR(shdev->chan_reg);
        if (dmars) {