scsi: mpt3sas: Signedness bug in _base_get_diag_triggers()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 9 Dec 2020 14:03:11 +0000 (17:03 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 9 Dec 2020 16:57:39 +0000 (11:57 -0500)
The "trigger_flags" variable needs to be signed for the error checking to
work.

Link: https://lore.kernel.org/r/X9DZH37bYPHwSQRP@mwanda
Fixes: aec93e8e2385 ("scsi: mpt3sas: Add persistent trigger pages support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_base.c

index b129f3734ed0acc63d1e7053da61be44b030f538..26537d503a8b66b63e5ceecedcb0c354cb281599 100644 (file)
@@ -5027,7 +5027,7 @@ _base_check_for_trigger_pages_support(struct MPT3SAS_ADAPTER *ioc)
 static void
 _base_get_diag_triggers(struct MPT3SAS_ADAPTER *ioc)
 {
-       u16 trigger_flags;
+       int trigger_flags;
 
        /*
         * Default setting of master trigger.