mt76: mt7921: do not always disable fw runtime-pm
authorLorenzo Bianconi <lorenzo@kernel.org>
Fri, 31 Dec 2021 11:36:02 +0000 (12:36 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Jul 2022 14:34:58 +0000 (16:34 +0200)
[ Upstream commit b44eeb8cbdf2b88f2844f11e4f263b0abed5b5b0 ]

After commit 'd430dffbe9dd ("mt76: mt7921: fix a possible race
enabling/disabling runtime-pm")', runtime-pm is always disabled in the
fw even if the user requests to enable it toggling debugfs node since
mt7921_pm_interface_iter routine will use pm->enable to configure the fw.
Fix the issue moving enable variable configuration before running
mt7921_pm_interface_iter routine.

Fixes: d430dffbe9dd ("mt76: mt7921: fix a possible race enabling/disabling runtime-pm")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/mediatek/mt76/mt7921/debugfs.c

index b9f25599227d254882b043eb2b37b69aba8d3b70..cfcf7964c6881496747ec29312cc241112cb1cfe 100644 (file)
@@ -291,13 +291,12 @@ mt7921_pm_set(void *data, u64 val)
        pm->enable = false;
        mt76_connac_pm_wake(&dev->mphy, pm);
 
+       pm->enable = val;
        ieee80211_iterate_active_interfaces(mt76_hw(dev),
                                            IEEE80211_IFACE_ITER_RESUME_ALL,
                                            mt7921_pm_interface_iter, dev);
 
        mt76_connac_mcu_set_deep_sleep(&dev->mt76, pm->ds_enable);
-
-       pm->enable = val;
        mt76_connac_power_save_sched(&dev->mphy, pm);
 out:
        mutex_unlock(&dev->mt76.mutex);