mm: compaction: only set skip flag if cc->no_set_skip_hint is false

To keep the same logic as test_and_set_skip(), only set the skip flag if
cc->no_set_skip_hint is false, which makes code more reasonable.

Link: https://lkml.kernel.org/r/0eb2cd2407ffb259ae6e3071e10f70f2d41d0f3e.1685018752.git.baolin.wang@linux.alibaba.com
Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Mel Gorman <mgorman@techsingularity.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/mm/compaction.c b/mm/compaction.c
index c5f97bfd629c848badb0b8e04a33897140b2558f..3b09d8d0258164b69c90a4c9facd8fda2af01aea 100644 (file)
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1201,7 +1201,7 @@ isolate_abort:
         * rescanned twice in a row.
         */
        if (low_pfn == end_pfn && (!nr_isolated || cc->finish_pageblock)) {
-               if (valid_page && !skip_updated)
+               if (!cc->no_set_skip_hint && valid_page && !skip_updated)
                        set_pageblock_skip(valid_page);
                update_cached_migrate(cc, low_pfn);
        }