xfs: simplify xfs_btree_check_lblock_siblings

Stop using xfs_btree_check_lptr in xfs_btree_check_lblock_siblings,
as it only duplicates the xfs_verify_fsbno call in the other leg of
if / else besides adding a tautological level check.

With this the cur and level arguments can be removed as they are
now unused.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>

diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
index cea5500a0ecee18fb34e0caa67c2dccc09ee19df..fc877188919e3d1c04e5f827c9ce67c631d0a21e 100644 (file)
--- a/fs/xfs/libxfs/xfs_btree.c
+++ b/fs/xfs/libxfs/xfs_btree.c
@@ -59,8 +59,6 @@ xfs_btree_magic(
 static inline xfs_failaddr_t
 xfs_btree_check_lblock_siblings(
        struct xfs_mount        *mp,
-       struct xfs_btree_cur    *cur,
-       int                     level,
        xfs_fsblock_t           fsb,
        __be64                  dsibling)
 {
@@ -72,14 +70,8 @@ xfs_btree_check_lblock_siblings(
        sibling = be64_to_cpu(dsibling);
        if (sibling == fsb)
                return __this_address;
-       if (level >= 0) {
-               if (!xfs_btree_check_lptr(cur, sibling, level + 1))
-                       return __this_address;
-       } else {
-               if (!xfs_verify_fsbno(mp, sibling))
-                       return __this_address;
-       }
-
+       if (!xfs_verify_fsbno(mp, sibling))
+               return __this_address;
        return NULL;
 }
 
@@ -139,10 +131,9 @@ __xfs_btree_check_lblock(
        if (bp)
                fsb = XFS_DADDR_TO_FSB(mp, xfs_buf_daddr(bp));
 
-       fa = xfs_btree_check_lblock_siblings(mp, cur, level, fsb,
-                       block->bb_u.l.bb_leftsib);
+       fa = xfs_btree_check_lblock_siblings(mp, fsb, block->bb_u.l.bb_leftsib);
        if (!fa)
-               fa = xfs_btree_check_lblock_siblings(mp, cur, level, fsb,
+               fa = xfs_btree_check_lblock_siblings(mp, fsb,
                                block->bb_u.l.bb_rightsib);
        return fa;
 }
@@ -4651,10 +4642,9 @@ xfs_btree_lblock_verify(
 
        /* sibling pointer verification */
        fsb = XFS_DADDR_TO_FSB(mp, xfs_buf_daddr(bp));
-       fa = xfs_btree_check_lblock_siblings(mp, NULL, -1, fsb,
-                       block->bb_u.l.bb_leftsib);
+       fa = xfs_btree_check_lblock_siblings(mp, fsb, block->bb_u.l.bb_leftsib);
        if (!fa)
-               fa = xfs_btree_check_lblock_siblings(mp, NULL, -1, fsb,
+               fa = xfs_btree_check_lblock_siblings(mp, fsb,
                                block->bb_u.l.bb_rightsib);
        return fa;
 }