KEYS: x509: remove dead code that set ->unsupported_sig
authorEric Biggers <ebiggers@google.com>
Wed, 19 Jan 2022 00:54:36 +0000 (16:54 -0800)
committerJarkko Sakkinen <jarkko@kernel.org>
Tue, 8 Mar 2022 08:33:18 +0000 (10:33 +0200)
The X.509 parser always sets cert->sig->pkey_algo and
cert->sig->hash_algo on success, since x509_note_sig_algo() is a
mandatory action in the X.509 ASN.1 grammar, and it returns an error if
the signature's algorithm is unknown.  Thus, remove the dead code which
handled these fields being NULL.

Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
crypto/asymmetric_keys/x509_public_key.c

index b03d04d78eb9d13212cb6b0bfe9516b9869d3e45..8c77a297a82d4b1959f993b07a084340e39b722d 100644 (file)
@@ -33,15 +33,6 @@ int x509_get_sig_params(struct x509_certificate *cert)
        sig->data = cert->tbs;
        sig->data_size = cert->tbs_size;
 
-       if (!sig->pkey_algo)
-               cert->unsupported_sig = true;
-
-       /* We check the hash if we can - even if we can't then verify it */
-       if (!sig->hash_algo) {
-               cert->unsupported_sig = true;
-               return 0;
-       }
-
        sig->s = kmemdup(cert->raw_sig, cert->raw_sig_size, GFP_KERNEL);
        if (!sig->s)
                return -ENOMEM;