projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
adfbae9
)
drm/i915: Fix memory leaks in i915 selftests
author
Cong Liu
<liucong2@kylinos.cn>
Fri, 14 Apr 2023 22:41:09 +0000
(
00:41
+0200)
committer
Andi Shyti
<andi.shyti@linux.intel.com>
Sat, 15 Apr 2023 20:38:54 +0000
(22:38 +0200)
This patch fixes memory leaks on error escapes in function fake_get_pages
Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation")
Signed-off-by: Cong Liu <liucong2@kylinos.cn>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Link:
https://patchwork.freedesktop.org/patch/msgid/20230414224109.1051922-1-andi.shyti@linux.intel.com
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
index 5361ce70d3f297b2614246cc0e8b961e2193738b..154801f1c4685bd9d266a5cad9c7628d95412ea3 100644
(file)
--- a/
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
+++ b/
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
@@
-69,8
+69,10
@@
static int fake_get_pages(struct drm_i915_gem_object *obj)
rem = round_up(obj->base.size, BIT(31)) >> 31;
/* restricted by sg_alloc_table */
- if (overflows_type(rem, unsigned int))
+ if (overflows_type(rem, unsigned int)) {
+ kfree(pages);
return -E2BIG;
+ }
if (sg_alloc_table(pages, rem, GFP)) {
kfree(pages);