mm: Use static initialisers for immutable fields of 'struct vm_fault'
authorWill Deacon <will@kernel.org>
Thu, 14 Jan 2021 15:42:14 +0000 (15:42 +0000)
committerWill Deacon <will@kernel.org>
Thu, 21 Jan 2021 12:50:18 +0000 (12:50 +0000)
In preparation for const-ifying the anonymous struct field of
'struct vm_fault', ensure that it is initialised using designated
initialisers.

Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Will Deacon <will@kernel.org>
mm/shmem.c
mm/swapfile.c

index 7c6b6d8f6c396d5c9f608a17983fbe7691c6b9cf..1b254fbfdf52efefb7336c9f16b13eae129fc3cf 100644 (file)
@@ -1520,11 +1520,11 @@ static struct page *shmem_swapin(swp_entry_t swap, gfp_t gfp,
 {
        struct vm_area_struct pvma;
        struct page *page;
-       struct vm_fault vmf;
+       struct vm_fault vmf = {
+               .vma = &pvma,
+       };
 
        shmem_pseudo_vma_init(&pvma, info, index);
-       vmf.vma = &pvma;
-       vmf.address = 0;
        page = swap_cluster_readahead(swap, gfp, &vmf);
        shmem_pseudo_vma_destroy(&pvma);
 
index 9fffc5af29d1b9136cfe8266bcf35fa645c0f747..2b570a5662764a037affecc6473bf1660063c9e2 100644 (file)
@@ -1951,8 +1951,6 @@ static int unuse_pte_range(struct vm_area_struct *vma, pmd_t *pmd,
        si = swap_info[type];
        pte = pte_offset_map(pmd, addr);
        do {
-               struct vm_fault vmf;
-
                if (!is_swap_pte(*pte))
                        continue;
 
@@ -1968,9 +1966,12 @@ static int unuse_pte_range(struct vm_area_struct *vma, pmd_t *pmd,
                swap_map = &si->swap_map[offset];
                page = lookup_swap_cache(entry, vma, addr);
                if (!page) {
-                       vmf.vma = vma;
-                       vmf.address = addr;
-                       vmf.pmd = pmd;
+                       struct vm_fault vmf = {
+                               .vma = vma,
+                               .address = addr,
+                               .pmd = pmd,
+                       };
+
                        page = swapin_readahead(entry, GFP_HIGHUSER_MOVABLE,
                                                &vmf);
                }