serial: 8250_lpss: copy dma_param using devm_kmemdup()
authorRaag Jadav <raag.jadav@intel.com>
Tue, 2 Jan 2024 05:50:06 +0000 (11:20 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Jan 2024 15:21:51 +0000 (16:21 +0100)
Use devm_kmemdup() helper to copy dma_param instead of doing it manually.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Link: https://lore.kernel.org/r/20240102055006.27256-1-raag.jadav@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_lpss.c

index 0e43bdfb745989c72a3d015b29b7cf8505777d42..776ec1ef29d62b9f9a3c57a43d571f7808b6096b 100644 (file)
@@ -287,17 +287,14 @@ static int lpss8250_dma_setup(struct lpss8250 *lpss, struct uart_8250_port *port
                return 0;
        }
 
-       rx_param = devm_kzalloc(dev, sizeof(*rx_param), GFP_KERNEL);
+       rx_param = devm_kmemdup(dev, &lpss->dma_param, sizeof(*rx_param), GFP_KERNEL);
        if (!rx_param)
                return -ENOMEM;
 
-       tx_param = devm_kzalloc(dev, sizeof(*tx_param), GFP_KERNEL);
+       tx_param = devm_kmemdup(dev, &lpss->dma_param, sizeof(*tx_param), GFP_KERNEL);
        if (!tx_param)
                return -ENOMEM;
 
-       *rx_param = lpss->dma_param;
-       *tx_param = lpss->dma_param;
-
        dma->fn = lpss8250_dma_filter;
        dma->rx_param = rx_param;
        dma->tx_param = tx_param;