cifs: remove redundant variable tcon_exist
authorColin Ian King <colin.i.king@gmail.com>
Tue, 16 Jan 2024 10:51:34 +0000 (10:51 +0000)
committerSteve French <stfrench@microsoft.com>
Tue, 16 Jan 2024 23:19:46 +0000 (17:19 -0600)
The variable tcon_exist is being assigned however it is never read, the
variable is redundant and can be removed.

Cleans up clang scan build warning:
warning: Although the value stored to 'tcon_exist' is used in
the enclosing expression, the value is never actually readfrom
'tcon_exist' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/smb2pdu.c

index bd25c34dc398b6460c37e3c1ea778fdc0cca6b80..50f6bf16b62453635c432361bac1316736b22747 100644 (file)
@@ -3918,7 +3918,7 @@ void smb2_reconnect_server(struct work_struct *work)
        struct cifs_ses *ses, *ses2;
        struct cifs_tcon *tcon, *tcon2;
        struct list_head tmp_list, tmp_ses_list;
-       bool tcon_exist = false, ses_exist = false;
+       bool ses_exist = false;
        bool tcon_selected = false;
        int rc;
        bool resched = false;
@@ -3964,7 +3964,7 @@ void smb2_reconnect_server(struct work_struct *work)
                        if (tcon->need_reconnect || tcon->need_reopen_files) {
                                tcon->tc_count++;
                                list_add_tail(&tcon->rlist, &tmp_list);
-                               tcon_selected = tcon_exist = true;
+                               tcon_selected = true;
                        }
                }
                /*
@@ -3973,7 +3973,7 @@ void smb2_reconnect_server(struct work_struct *work)
                 */
                if (ses->tcon_ipc && ses->tcon_ipc->need_reconnect) {
                        list_add_tail(&ses->tcon_ipc->rlist, &tmp_list);
-                       tcon_selected = tcon_exist = true;
+                       tcon_selected = true;
                        cifs_smb_ses_inc_refcount(ses);
                }
                /*