binfmt_flat: Drop vestiges of coredump support
authorEric W. Biederman <ebiederm@xmission.com>
Tue, 19 Apr 2022 14:16:41 +0000 (09:16 -0500)
committerKees Cook <keescook@chromium.org>
Wed, 20 Apr 2022 02:31:43 +0000 (19:31 -0700)
There is the briefest start of coredump support in binfmt_flat. It
is actually a pain to maintain as binfmt_flat is not built on most
architectures so it is easy to overlook.

Since the support does not do anything remove it.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
Acked-by: Greg Ungerer <gerg@linux-m68k.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/87mtgh17li.fsf_-_@email.froward.int.ebiederm.org
fs/binfmt_flat.c

index dca0b6875f9c3c1961b14524362fdb36ffa3788e..c03563e20e240212106532e22ec5c857c4886f97 100644 (file)
@@ -37,7 +37,6 @@
 #include <linux/flat.h>
 #include <linux/uaccess.h>
 #include <linux/vmalloc.h>
-#include <linux/coredump.h>
 
 #include <asm/byteorder.h>
 #include <asm/unaligned.h>
@@ -98,33 +97,12 @@ static int load_flat_shared_library(int id, struct lib_info *p);
 #endif
 
 static int load_flat_binary(struct linux_binprm *);
-#ifdef CONFIG_COREDUMP
-static int flat_core_dump(struct coredump_params *cprm);
-#endif
 
 static struct linux_binfmt flat_format = {
        .module         = THIS_MODULE,
        .load_binary    = load_flat_binary,
-#ifdef CONFIG_COREDUMP
-       .core_dump      = flat_core_dump,
-       .min_coredump   = PAGE_SIZE
-#endif
 };
 
-/****************************************************************************/
-/*
- * Routine writes a core dump image in the current directory.
- * Currently only a stub-function.
- */
-
-#ifdef CONFIG_COREDUMP
-static int flat_core_dump(struct coredump_params *cprm)
-{
-       pr_warn("Process %s:%d received signr %d and should have core dumped\n",
-               current->comm, current->pid, cprm->siginfo->si_signo);
-       return 1;
-}
-#endif
 
 /****************************************************************************/
 /*