ahci: drop unused board_ahci_noncq
authorNiklas Cassel <cassel@kernel.org>
Wed, 14 Feb 2024 13:00:11 +0000 (14:00 +0100)
committerNiklas Cassel <cassel@kernel.org>
Mon, 19 Feb 2024 08:51:56 +0000 (09:51 +0100)
Since commit 66a7cbc303f4 ("ahci: disable MSI instead of NCQ on Samsung
pci-e SSDs on macbooks") there is not a single entry in ahci_pci_tbl
which uses board_ahci_noncq.

Since this is dead code, let's remove it.
We cannot remove AHCI_HFLAG_NO_NCQ, as this flag is still used by other
boards.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Niklas Cassel <cassel@kernel.org>
drivers/ata/ahci.c

index d8e5b26524f6b38c2b8ef6408f80cd90753f20e6..9bff90fb05912197ac65ff6cf5f559807f4faf97 100644 (file)
@@ -52,7 +52,6 @@ enum board_ids {
        board_ahci_ign_iferr,
        board_ahci_no_debounce_delay,
        board_ahci_nomsi,
-       board_ahci_noncq,
        /*
         * board_ahci_pcs_quirk is for legacy Intel platforms.
         * Modern Intel platforms should use board_ahci instead.
@@ -159,13 +158,6 @@ static const struct ata_port_info ahci_port_info[] = {
                .udma_mask      = ATA_UDMA6,
                .port_ops       = &ahci_ops,
        },
-       [board_ahci_noncq] = {
-               AHCI_HFLAGS     (AHCI_HFLAG_NO_NCQ),
-               .flags          = AHCI_FLAG_COMMON,
-               .pio_mask       = ATA_PIO4,
-               .udma_mask      = ATA_UDMA6,
-               .port_ops       = &ahci_ops,
-       },
        [board_ahci_pcs_quirk] = {
                AHCI_HFLAGS     (AHCI_HFLAG_INTEL_PCS_QUIRK),
                .flags          = AHCI_FLAG_COMMON,