staging: vchiq: drop trailing semicolon in macro definition
authorGaston Gonzalez <gascoar@gmail.com>
Sun, 24 Oct 2021 21:25:21 +0000 (18:25 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 25 Oct 2021 07:12:09 +0000 (09:12 +0200)
As reported by checkpatch.pl, macro definitions should not use a trailing
semicolon.

Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
Link: https://lore.kernel.org/r/20211024212524.370078-6-gascoar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c

index a5e33da74726199db607ca7a9d5e023016721bb5..c650a32bcedfffa1c4540c2ce7ad9fc93d2450b0 100644 (file)
@@ -986,7 +986,7 @@ add_completion(struct vchiq_instance *instance, enum vchiq_reason reason,
        struct vchiq_completion_data_kernel *completion;
        int insert;
 
-       DEBUG_INITIALISE(g_state.local)
+       DEBUG_INITIALISE(g_state.local);
 
        insert = instance->completion_insert;
        while ((insert - instance->completion_remove) >= MAX_COMPLETIONS) {
@@ -1054,7 +1054,7 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header,
        struct vchiq_instance *instance;
        bool skip_completion = false;
 
-       DEBUG_INITIALISE(g_state.local)
+       DEBUG_INITIALISE(g_state.local);
 
        DEBUG_TRACE(SERVICE_CALLBACK_LINE);
 
index d64d6a0427eb5359395af87f625ff0c59bf9c1e5..22d0e706b2dc4c58f3c8ad430809dfce493b0aed 100644 (file)
@@ -1585,7 +1585,7 @@ parse_message(struct vchiq_state *state, struct vchiq_header *header)
        unsigned int localport, remoteport;
        int msgid, size, type, ret = -EINVAL;
 
-       DEBUG_INITIALISE(state->local)
+       DEBUG_INITIALISE(state->local);
 
        DEBUG_VALUE(PARSE_HEADER, (int)(long)header);
        msgid = header->msgid;
@@ -1856,7 +1856,7 @@ parse_rx_slots(struct vchiq_state *state)
        struct vchiq_shared_state *remote = state->remote;
        int tx_pos;
 
-       DEBUG_INITIALISE(state->local)
+       DEBUG_INITIALISE(state->local);
 
        tx_pos = remote->tx_pos;
 
@@ -1961,7 +1961,7 @@ slot_handler_func(void *v)
        struct vchiq_state *state = v;
        struct vchiq_shared_state *local = state->local;
 
-       DEBUG_INITIALISE(local)
+       DEBUG_INITIALISE(local);
 
        while (1) {
                DEBUG_COUNT(SLOT_HANDLER_COUNT);
index a107c72ce3a69cf0087e9f2318f40bb46d85fd2a..e54e9d80bd7ffc12ecc37bd7422c54657bc7dc0b 100644 (file)
@@ -104,7 +104,7 @@ enum {
 
 #if VCHIQ_ENABLE_DEBUG
 
-#define DEBUG_INITIALISE(local) int *debug_ptr = (local)->debug;
+#define DEBUG_INITIALISE(local) int *debug_ptr = (local)->debug
 #define DEBUG_TRACE(d) \
        do { debug_ptr[DEBUG_ ## d] = __LINE__; dsb(sy); } while (0)
 #define DEBUG_VALUE(d, v) \
index 32aa1e62450d4678173e7131ed52387dcaaa509b..2325844b08806db031037e5423ee81524ff7df3f 100644 (file)
@@ -210,7 +210,7 @@ static int vchiq_ioc_dequeue_message(struct vchiq_instance *instance,
        struct vchiq_header *header;
        int ret;
 
-       DEBUG_INITIALISE(g_state.local)
+       DEBUG_INITIALISE(g_state.local);
        DEBUG_TRACE(DEQUEUE_MESSAGE_LINE);
        service = find_service_for_instance(instance, args->handle);
        if (!service)
@@ -439,7 +439,7 @@ static int vchiq_ioc_await_completion(struct vchiq_instance *instance,
        int remove;
        int ret;
 
-       DEBUG_INITIALISE(g_state.local)
+       DEBUG_INITIALISE(g_state.local);
 
        DEBUG_TRACE(AWAIT_COMPLETION_LINE);
        if (!instance->connected)