tools/power/x86/intel-speed-select: Fix mailbox usage for CLOS_PM_QOS_CONFIG
authorSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Tue, 3 Mar 2020 22:50:43 +0000 (14:50 -0800)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 20 Mar 2020 12:46:01 +0000 (14:46 +0200)
Even for the products using MMIO, this message needs to be sent via
mail box. The previous fix done for this didn't properly address this.
That fix simply removed sending command via MMIO, but still didn't
trigger sending via mailbox.

Add additional condition to check for CLOS_PM_QOS_CONFIG, when MMIO
is supported on a platform.

Fixes: cd0e63706549 (tools/power/x86/intel-speed-select: Use mailbox for CLOS_PM_QOS_CONFIG)
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
tools/power/x86/intel-speed-select/isst-config.c

index 0cf3548681f8bbac145b7c3f432e9fe2e328ce15..50db0cd23d8c16cf20d7f311528e034400d67ebe 100644 (file)
@@ -572,7 +572,8 @@ int isst_send_mbox_command(unsigned int cpu, unsigned char command,
                "mbox_send: cpu:%d command:%x sub_command:%x parameter:%x req_data:%x\n",
                cpu, command, sub_command, parameter, req_data);
 
-       if (isst_platform_info.mmio_supported && command == CONFIG_CLOS) {
+       if (isst_platform_info.mmio_supported && command == CONFIG_CLOS &&
+           sub_command != CLOS_PM_QOS_CONFIG) {
                unsigned int value;
                int write = 0;
                int clos_id, core_id, ret = 0;