drm/amd/display: Allow 16 max_slices for DP2 DSC
authorFangzhi Zuo <jerry.zuo@amd.com>
Wed, 18 Oct 2023 13:38:33 +0000 (09:38 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 7 Nov 2023 16:17:03 +0000 (11:17 -0500)
Enable 12 and 16 max_slices for DP2 DSC

Reviewed-by: Alvin Lee <alvin.lee2@amd.com>
Acked-by: Hersen Wu <hersenxs.wu@amd.com>
Signed-off-by: Fangzhi Zuo <jerry.zuo@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c
drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
drivers/gpu/drm/amd/display/dc/inc/hw/dsc.h

index 5eebe7f03ddc72a8b060ec4768b5e7753b827942..c9ae2d8f0096fa4c63ffb2167059eaaf59227f00 100644 (file)
@@ -137,7 +137,15 @@ void dsc2_get_enc_caps(struct dsc_enc_caps *dsc_enc_caps, int pixel_clock_100Hz)
                dsc_enc_caps->max_total_throughput_mps = DCN20_MAX_DISPLAY_CLOCK_Mhz * 2;
        }
 
-       // TODO DSC: This is actually image width limitation, not a slice width. This should be added to the criteria to use ODM.
+       /* For pixel clock bigger than a single-pipe limit needing four engines ODM 4:1, which then quardruples our
+        * throughput and number of slices
+        */
+       if (pixel_clock_100Hz > DCN20_MAX_PIXEL_CLOCK_Mhz*10000*2) {
+               dsc_enc_caps->slice_caps.bits.NUM_SLICES_12 = 1;
+               dsc_enc_caps->slice_caps.bits.NUM_SLICES_16 = 1;
+               dsc_enc_caps->max_total_throughput_mps = DCN20_MAX_DISPLAY_CLOCK_Mhz * 4;
+       }
+
        dsc_enc_caps->max_slice_width = 5184; /* (including 64 overlap pixels for eDP MSO mode) */
        dsc_enc_caps->bpp_increment_div = 16; /* 1/16th of a bit */
 }
index 3966845c769453888675b80c32ede95c0b62fa5f..e8b5f17beb9636ca95ced0f4cd05631b02f42e3a 100644 (file)
@@ -512,6 +512,11 @@ static bool intersect_dsc_caps(
                dsc_sink_caps->slice_caps1.bits.NUM_SLICES_4 && dsc_enc_caps->slice_caps.bits.NUM_SLICES_4;
        dsc_common_caps->slice_caps.bits.NUM_SLICES_8 =
                dsc_sink_caps->slice_caps1.bits.NUM_SLICES_8 && dsc_enc_caps->slice_caps.bits.NUM_SLICES_8;
+       dsc_common_caps->slice_caps.bits.NUM_SLICES_12 =
+               dsc_sink_caps->slice_caps1.bits.NUM_SLICES_12 && dsc_enc_caps->slice_caps.bits.NUM_SLICES_12;
+       dsc_common_caps->slice_caps.bits.NUM_SLICES_16 =
+               dsc_sink_caps->slice_caps2.bits.NUM_SLICES_16 && dsc_enc_caps->slice_caps.bits.NUM_SLICES_16;
+
        if (!dsc_common_caps->slice_caps.raw)
                return false;
 
@@ -703,6 +708,12 @@ static int get_available_dsc_slices(union dsc_enc_slice_caps slice_caps, int *av
        if (slice_caps.bits.NUM_SLICES_8)
                available_slices[idx++] = 8;
 
+       if (slice_caps.bits.NUM_SLICES_12)
+               available_slices[idx++] = 12;
+
+       if (slice_caps.bits.NUM_SLICES_16)
+               available_slices[idx++] = 16;
+
        return idx;
 }
 
index d7b8d586b5237e9a8ecb67c1cbf9254a2f38c1d3..4b27f29d0d80d9666c4c4af350f4d5ddf5b88fea 100644 (file)
@@ -76,6 +76,8 @@ union dsc_enc_slice_caps {
                uint8_t NUM_SLICES_3 : 1; /* This one is not per DSC spec, but our encoder supports it */
                uint8_t NUM_SLICES_4 : 1;
                uint8_t NUM_SLICES_8 : 1;
+               uint8_t NUM_SLICES_12 : 1;
+               uint8_t NUM_SLICES_16 : 1;
        } bits;
        uint8_t raw;
 };