i3c/master: Fix uninitialized variable next_addr
authorColin Ian King <colin.king@canonical.com>
Tue, 24 Nov 2020 12:35:04 +0000 (12:35 +0000)
committerBoris Brezillon <boris.brezillon@collabora.com>
Wed, 25 Nov 2020 10:02:43 +0000 (11:02 +0100)
The variable next_addr is not initialized and is being used in a call
to i3c_master_get_free_addr as a starting point to find the next address.
Fix this by initializing next_addr to 0 to avoid an uninitialized garbage
starting address from being used.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 9ad9a52cce28 ("i3c/master: introduce the mipi-i3c-hci driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Nicolas Pitre <npitre@baylibre.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://lore.kernel.org/linux-i3c/20201124123504.396249-1-colin.king@canonical.com
drivers/i3c/master/mipi-i3c-hci/cmd_v1.c

index 6dd234a82892f9db4050d87f2b77d36ce572743a..d97c3175e0e2784ed6f53111d5a8d4aa9f3e8334 100644 (file)
@@ -293,7 +293,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci)
 {
        struct hci_xfer *xfer;
        int ret, dat_idx = -1;
-       u8 next_addr;
+       u8 next_addr = 0;
        u64 pid;
        unsigned int dcr, bcr;
        DECLARE_COMPLETION_ONSTACK(done);