dmaengine: sf-pdma: Support of_dma_controller_register()
authorShravan Chippa <shravan.chippa@microchip.com>
Fri, 8 Dec 2023 10:38:53 +0000 (16:08 +0530)
committerVinod Koul <vkoul@kernel.org>
Mon, 11 Dec 2023 11:03:22 +0000 (16:33 +0530)
Update sf-pdma driver to adopt generic DMA device tree bindings.
It calls of_dma_controller_register() with of_dma_xlate_by_chan_id
to get the generic DMA device tree helper support and the DMA
clients can look up the sf-pdma controller using standard APIs.

Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com>
Link: https://lore.kernel.org/r/20231208103856.3732998-2-shravan.chippa@microchip.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/sf-pdma/sf-pdma.c

index 3125a2f162b4788d3ffbf182265bff18532ba19c..6109e1c5a09eacbf9fa0b9d94e59763373e6a2b9 100644 (file)
@@ -20,6 +20,7 @@
 #include <linux/mod_devicetable.h>
 #include <linux/dma-mapping.h>
 #include <linux/of.h>
+#include <linux/of_dma.h>
 #include <linux/slab.h>
 
 #include "sf-pdma.h"
@@ -563,7 +564,20 @@ static int sf_pdma_probe(struct platform_device *pdev)
                return ret;
        }
 
+       ret = of_dma_controller_register(pdev->dev.of_node,
+                                        of_dma_xlate_by_chan_id, pdma);
+       if (ret < 0) {
+               dev_err(&pdev->dev,
+                       "Can't register SiFive Platform OF_DMA. (%d)\n", ret);
+               goto err_unregister;
+       }
+
        return 0;
+
+err_unregister:
+       dma_async_device_unregister(&pdma->dma_dev);
+
+       return ret;
 }
 
 static void sf_pdma_remove(struct platform_device *pdev)
@@ -583,6 +597,9 @@ static void sf_pdma_remove(struct platform_device *pdev)
                tasklet_kill(&ch->err_tasklet);
        }
 
+       if (pdev->dev.of_node)
+               of_dma_controller_free(pdev->dev.of_node);
+
        dma_async_device_unregister(&pdma->dma_dev);
 }